https://github.com/kvirc/KVIrc.git https://cgit.space/~irc/github.com/kvirc/KVIrc.git/atom/src/modules/logview/ExportOperation.cpp?h=master 2023-10-18T08:26:35Z 2023-10-18T08:26:35Z Fabio Bas 2023-10-04T09:25:05Z urn:sha1:29e92a939647612842b2f583ce0a43dd572b1345 Method str_kvs_fnc_split() had to be replaced with the original version, since the newer one relied on Qt5's QStringRef 2023-10-18T08:26:35Z Fabio Bas 2023-09-27T15:22:01Z urn:sha1:2e402d15b5eb28cc70ce5783ebf6473bab97949a cast 2023-08-05T08:39:01Z Chris MacLeod 2023-08-05T08:39:01Z urn:sha1:2b021749ce4dc3ec8e160a5800e323f7a45047db * Implement most basic functional batch export For the future: * The loop still needs to be made asynchronous so the process doesn't hang. * Ideally, there should be some sort of progress window. * There is redundant code that should be reduced. * Make batch export asynchronous Reminder: The comment about overwrite protection no longer applies Todo: Progress dialog * Avoid possible dangling pointer, improve type safety and const correctness in the process In reality, the log exporting code has no reason to be in the GUI class to begin with. `exportLog` makes sense as a Qt slot, but `createLog` should be a member function of the `LogFile` class and operate on `this` rather than a `LogFile` argument. A future commit should amend this, but for now I will avoid changing anything unnecessary until a working progress dialog is in place and I have tested the finished feature thoroughly. * Add progress dialog * Make LogViewWindow::createLog a member function of LogFile * Reduce memory usage by sharing `LogFile`s with the GUI thread * Correct progress dialog modality * Collect log files directly instead of reiterating through view items later Also adds a little documentation * Fix batch export for paths with reserved characters * avoid sigsegv * fix tags removal before nickname in html export * Fix directory selection and output path for icons in html export --------- Co-authored-by: ctrlaltca <ctrlaltca@gmail.com>