From 75af3ecbab799de70fe2b79cd72c8cc705ff430a Mon Sep 17 00:00:00 2001
From: Igor V. Kovalenko
Date: Mon, 13 Nov 2023 19:35:49 +0300
Subject: Fix text[idx] out of bounds assertion in
 KviTopicWidget::paintColoredText (#2561)

---
 src/kvirc/ui/KviTopicWidget.cpp | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/src/kvirc/ui/KviTopicWidget.cpp b/src/kvirc/ui/KviTopicWidget.cpp
index d37b53353..fd0251832 100644
--- a/src/kvirc/ui/KviTopicWidget.cpp
+++ b/src/kvirc/ui/KviTopicWidget.cpp
@@ -184,6 +184,22 @@ void KviTopicWidget::applyOptions()
 	m_pLabel->setText(KviHtmlGenerator::convertToHtml(m_szTopic, true));
 }
 
+static bool isKviControlCode(unsigned short c)
+{
+	switch (c) {
+	case KviControlCodes::Color:
+	case KviControlCodes::Bold:
+	case KviControlCodes::Italic:
+	case KviControlCodes::Underline:
+	case KviControlCodes::Reverse:
+	case KviControlCodes::Reset:
+	case KviControlCodes::Icon:
+		return true;
+	default:
+		return false;
+	}
+}
+
 void KviTopicWidget::paintColoredText(QPainter * p, QString text, const QPalette & cg, const QRect & rect)
 {
 	QFontMetrics fm(p->fontMetrics());
@@ -202,15 +218,17 @@ void KviTopicWidget::paintColoredText(QPainter * p, QString text, const QPalette
 
 	while((idx < (unsigned int)text.length()) && (curX < maxX))
 	{
-		unsigned short c = text[(int)idx].unicode();
-
+		unsigned short c;
 		unsigned int start = idx;
 
-		while((idx < (unsigned int)text.length()) && (c != KviControlCodes::Color) && (c != KviControlCodes::Bold) && (c != KviControlCodes::Italic) && (c != KviControlCodes::Underline) && (c != KviControlCodes::Reverse) && (c != KviControlCodes::Reset) && (c != KviControlCodes::Icon))
+		do
 		{
-			idx++;
 			c = text[(int)idx].unicode();
-		}
+			if (isKviControlCode(c))
+				break;
+
+			idx++;
+		} while((idx < (unsigned int)text.length()));
 
 		int len = idx - start;
 		int wdth;
-- 
cgit v1.3.1-10-gc9f91