From 66de67769296eff3d535f91d80fa3c97cd11cf7a Mon Sep 17 00:00:00 2001
From: staticfox
Date: Mon, 8 Aug 2016 04:50:34 -0400
Subject: void range-for loops when things are being destroyed

Otherwise, the iterator gets invalidated and undefined behaviour
can occur.
---
 src/modules/links/libkvilinks.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'src/modules/links/libkvilinks.cpp')

diff --git a/src/modules/links/libkvilinks.cpp b/src/modules/links/libkvilinks.cpp
index 5508d5e05..1f779032a 100644
--- a/src/modules/links/libkvilinks.cpp
+++ b/src/modules/links/libkvilinks.cpp
@@ -87,9 +87,8 @@ static bool links_module_init(KviModule * m)
 
 static bool links_module_cleanup(KviModule *)
 {
-	for(auto & l : g_pLinksWindowList)
-		l->die();
-	g_pLinksWindowList.clear();
+	while (!g_pLinksWindowList.empty())
+		(*g_pLinksWindowList.begin())->die();
 	return true;
 }
 
-- 
cgit v1.3.1-10-gc9f91