https://github.com/solanum-ircd/solanum https://cgit.space/~irc/github.com/solanum-ircd/solanum.git/atom/include/authproc.h?h=amdj%2Fmodules 2023-01-11T01:28:32Z 2023-01-11T01:28:32Z Aaron Jones 2023-01-11T01:28:32Z urn:sha1:fbc97166a6e455f5cccf173abca3b9baedee4066 authd child processes are only told about configured DNSBLs when the configuration is being parsed. This is bad, because when authd crashes or is killed, IRCd will restart it, but will not tell it about any configured DNSBLs until IRCd is next rehashed. We already have a dictionary that stores configured DNSBLs (for hit statistics for `STATS n'), so store the additional needed fields in that structure, and loop over that dictionary's entries when authd is restarted, sending the fields just as if the configuration were being reloaded. Reported-By: @Unit193 2021-06-01T16:40:02Z Ariadne Conill 2021-06-01T16:40:02Z urn:sha1:3fc0499e77c9091ce08a8c6da277de3a45c0c027 2020-10-15T14:52:41Z Ed Kellett 2020-10-15T14:51:12Z urn:sha1:a6f63a829e22fa83a4551cb9aad3e316e7c8bb18 2020-07-06T03:20:31Z Ariadne Conill 2020-07-06T03:01:56Z urn:sha1:3321eef45a3a76f9c026bae5ae3f5dfbf4edf7fd 2016-04-25T20:43:21Z Simon Arlott 2016-04-25T20:35:58Z urn:sha1:762468f85d2f99c3b51ffc9800ae55b945c798e6 It's useful to allow authd to run in parallel with ssl negotiation, but if the ssld connection has plaintext data ready for reading there's a race condition between authd calling read_packet() and ssl_process_certfp() storing the certificate fingerprint. This scenario would be bad for a server connecting because fingerprint verification will fail. Allow either operation to complete first, but wait until ssl_process_open_fd() calls the ssl open callback before calling read_packet(). 2016-04-12T14:43:50Z Elizabeth Myers 2016-04-12T14:43:50Z urn:sha1:4f2b9a4fd1884852dfecf4855299787fe0553cc8 2016-04-12T14:36:09Z Elizabeth Myers 2016-04-12T14:33:51Z urn:sha1:5e9a3f8674371a30dc1c94e6961ef86d09f846ee It's a bit of a hack, but better than before. Rather than rehashing (which could get us into an endless loop), we now segregate the configuration phase (creating entries ircd-side in case we restart authd later) and sending phases (when configure_authd() is called). Since we have to call configure_authd() no matter what (to send timeouts etc.) and we have to send this data to configure authd anyway, and sending duplicate data is bad, this is the only way I can think of for now. 2016-04-03T00:45:27Z Elizabeth Myers 2016-04-03T00:45:27Z urn:sha1:3d2fc110e35563ab29f97c6255adb4c9b0cafbe2 2016-04-02T21:44:04Z Elizabeth Myers 2016-04-02T21:44:04Z urn:sha1:64fae2607a1572412874486675da68ca568b03e3