https://github.com/solanum-ircd/solanum https://cgit.space/~irc/github.com/solanum-ircd/solanum.git/atom/include/defaults.h?h=amdj%2Fautotools-version-fix 2026-03-22T00:10:35Z 2026-03-22T00:10:35Z Aaron Jones 2026-03-11T03:57:11Z urn:sha1:232c2c13c64f3b1373eef16645b90bdb3233210d The existing code had several defects: - Core module file names were hardcoded, while autoloaded non- core module filenames were not. Code that loaded core modules had a different but in some places duplicated structure to the code that loaded autoloaded modules. - Module loading for autoloaded modules happened in dentry order, making it unpredictable from one server to the next, or even across instances of `make install` on the same server. - Module loading for autoloaded modules did not verify that the dentry was a file before trying to load it. - An IRCd start (or a conftest) only printed lines about loading modules mentioned in the configuration file. - The configuration file was parsed before loading core and autoloaded modules, meaning any modules specified in the configuration file would be loaded first. - Once a module was loaded, it was added to the head of the module list, making MODLIST show them in reverse loaded order (newest (re)loaded modules at the top of the list). These are addressed as follows: - We now scan the core and autoload module directories and use this to determine which modules to load. - We now sort the dentries according to their filename before iterating them to load them, making module load order finally deterministic. - We now test if a dentry is actually a file before trying to load it. - We now print a message to the console (if running in foreground or conftest mode) when loading any module, including core and autoloaded modules. - The message printed to the console now has the IRCd module directory prefix stripped from it if it matches. - The configuration file is now parsed after loading core and autoload modules. - The modules are added to the module list in the order that they are loaded. This now makes MODLIST show the order that modules were (re)loaded in. Modifications to two modules are part of this effort: - The autoload module `m_alias` relied upon the alias dict not being NULL when loaded, but this is only the case after the configuration file has been parsed. The module already had a "rehash" hook to destroy all existing aliases and create new ones, so we can just make the module do nothing on load (remove its modinit function) and change it to use the "conf_read_end" hook instead of the "rehash" hook, and it will still create aliases after the configuration file is subsequently parsed. With this modification, there are now no in-tree consumers of the "rehash" hook. - The autoload module `m_services` iterated `service_list` upon loading it, which will now be empty (a no-op) since the module is loaded before configuration file is parsed. This module too handles the configuration file being parsed with a "conf_read_end" hook and takes the appropriate action, so we can just remove this code from its modinit function. All other modules' modinit functions have been audited for behaviour like this; there was nothing of note. 2020-07-06T03:20:34Z Ariadne Conill 2020-07-06T03:18:23Z urn:sha1:a389de2a25ed3b57fb7336b317122ef76320e9ed 2016-04-07T09:47:48Z Elizabeth Myers 2016-04-07T09:47:48Z urn:sha1:9057170ce88071c67809c3648ae7f82883cc8567 Clean up spaces/tabs mixing mess (bleh), add some defaults for authd stuff, and get rid of CHARYBDIS_SOMAXCONN (just define SOMAXCONN if it's available...). 2016-03-24T23:45:28Z William Pitcock 2016-03-24T23:45:28Z urn:sha1:4d8cfacd95530550b075c38efa447d5673cb822e 2016-03-20T00:14:26Z Elizabeth Myers 2016-03-20T00:14:26Z urn:sha1:9b8e9eb32116eb171a951fbbe93c53f1047c9a34 2016-03-07T11:01:31Z Elizabeth Myers 2016-03-07T11:01:31Z urn:sha1:638d286293b1b3f75961d049a6e3c2c045e659e7 2016-03-06T08:47:27Z Elizabeth Myers 2016-03-06T08:46:13Z urn:sha1:cbeab4bc340b7b3f4fbf424ff327758defb9598a These are obsolete and none have changed since 10 years gao... 2015-03-26T19:46:54Z Aaron Jones 2014-07-13T00:00:00Z urn:sha1:c9b5cd623b56645b3a998fbaa201214f3118c187 2013-10-29T09:32:28Z Keith Buck 2013-10-29T09:07:19Z urn:sha1:7f3382fe9850560163130fab3a09b45c2165b090 Default values for default_floodcount and default_ident_timeout are set in s_conf.c. Remove code that checks for missing values in ircd.c. Additionally, reset default_ident_timeout to 5 if an invalid value (i.e. 0) is provided. 2008-04-05T19:56:15Z Valery Yatsko 2008-04-05T19:56:15Z urn:sha1:101db4c4433a7b30fe5986583abc898f554ebd7b