https://github.com/solanum-ircd/solanum https://cgit.space/~irc/github.com/solanum-ircd/solanum.git/atom/ircd?h=amdj%2Fautotools-version-fix 2026-04-29T16:12:34Z 2026-04-29T16:12:34Z Ryan Schmidt 2026-04-11T04:05:08Z urn:sha1:eacc3388cd75060a1ece9209c24c85bc20b65ff7 When loading a module that modifies config (add/remove conf items or top conf sections), we now queue a rehash operation so that new config can be immediately applied. A new rb_defer_once() function was added to deduplicate these rehash requests so that at most one rehash will occur regardless of how many modules change conf. 2026-04-05T19:44:06Z Ryan Schmidt 2026-03-29T04:48:30Z urn:sha1:ce3b170671eefd9a6612c62de7b8bd5c7ea329fb - Initialize hooks before the main log file, because if we send a snote due to failing to open a logfile, that calls a hook. Attempting to call a hook before hooks are initialized will cause the ircd to segfault. - Skip access() check for the logfile itself and simply check the return value of fopen(). This fixes a TOCTTOU race where an access check succeeds but something causes the file to become inaccessible between access() and fopen(), preventing an appropriate error from being logged. Also makes my life easier with my custom SELinux policy for the ircd since access() checks for full-write access whereas my policy only allows append access for logfiles. 2026-04-05T19:40:11Z Ryan Schmidt 2026-03-26T14:57:01Z urn:sha1:53ddbc4a9fdd26d7604cfdaac79deb33625398a7 2026-04-05T19:40:11Z Ryan Schmidt 2026-03-26T05:05:32Z urn:sha1:7b327076084b71ae7879f4d8cb1ad33e6ac229d4 The ban.db file as well as both MOTD files were in hardcoded locations. Add new config options to the main solanum binary to manipulate where these files are looked for. This should make it fully possible to run multiple solanum instances from the same directory side-by-side. 2026-03-22T15:19:53Z Aaron Jones 2026-03-22T03:00:11Z urn:sha1:6ac4d0e24e4b872b9f30adc743cf743e964d75d1 Commit 9a1ee1b64ed660164197 introduced support for building IRCd with Meson. It defines the "HAVE_OPENSSL" preprocessor macro for both IRCd and librb. While librb does use that macro, IRCd unfortunately uses only the "HAVE_LIBCRYPTO" macro instead, set implicitly by AC_CHECK_LIB from autotools. Make the autotools build system define HAVE_OPENSSL (to unify IRCd with librb) and change IRCd to use that. 2026-03-22T00:10:35Z Aaron Jones 2026-03-11T03:57:11Z urn:sha1:232c2c13c64f3b1373eef16645b90bdb3233210d The existing code had several defects: - Core module file names were hardcoded, while autoloaded non- core module filenames were not. Code that loaded core modules had a different but in some places duplicated structure to the code that loaded autoloaded modules. - Module loading for autoloaded modules happened in dentry order, making it unpredictable from one server to the next, or even across instances of `make install` on the same server. - Module loading for autoloaded modules did not verify that the dentry was a file before trying to load it. - An IRCd start (or a conftest) only printed lines about loading modules mentioned in the configuration file. - The configuration file was parsed before loading core and autoloaded modules, meaning any modules specified in the configuration file would be loaded first. - Once a module was loaded, it was added to the head of the module list, making MODLIST show them in reverse loaded order (newest (re)loaded modules at the top of the list). These are addressed as follows: - We now scan the core and autoload module directories and use this to determine which modules to load. - We now sort the dentries according to their filename before iterating them to load them, making module load order finally deterministic. - We now test if a dentry is actually a file before trying to load it. - We now print a message to the console (if running in foreground or conftest mode) when loading any module, including core and autoloaded modules. - The message printed to the console now has the IRCd module directory prefix stripped from it if it matches. - The configuration file is now parsed after loading core and autoload modules. - The modules are added to the module list in the order that they are loaded. This now makes MODLIST show the order that modules were (re)loaded in. Modifications to two modules are part of this effort: - The autoload module `m_alias` relied upon the alias dict not being NULL when loaded, but this is only the case after the configuration file has been parsed. The module already had a "rehash" hook to destroy all existing aliases and create new ones, so we can just make the module do nothing on load (remove its modinit function) and change it to use the "conf_read_end" hook instead of the "rehash" hook, and it will still create aliases after the configuration file is subsequently parsed. With this modification, there are now no in-tree consumers of the "rehash" hook. - The autoload module `m_services` iterated `service_list` upon loading it, which will now be empty (a no-op) since the module is loaded before configuration file is parsed. This module too handles the configuration file being parsed with a "conf_read_end" hook and takes the appropriate action, so we can just remove this code from its modinit function. All other modules' modinit functions have been audited for behaviour like this; there was nothing of note. 2026-03-19T10:27:23Z Ryan Schmidt 2026-03-18T23:42:09Z urn:sha1:f06fda5bbc1ce6a5fc858fc85f290e51fbd74e70 This has been recently ratified and suppresses NAMES output during channel joins when enabled, providing for a decent chunk of bandwidth savings. 2026-03-17T22:39:01Z Valentin Lorentz 2026-03-15T00:46:40Z urn:sha1:9a1ee1b64ed660164197e6362bcbedba2a9175ca 2026-03-17T22:39:01Z Valentin Lorentz 2026-03-15T00:34:40Z urn:sha1:747c14c6f62c974615af8056243728b80bf9a536 2026-03-17T22:39:01Z Valentin Lorentz 2026-03-15T00:31:44Z urn:sha1:6ba61b33f7ec557c02c1a631b83f9fc334c3fbee