object/store/packed/internal/ingest: Test that the bloom filter contains

1 files changed, 73 insertions, 0 deletions

diff --git a/object/store/packed/internal/ingest/writepack_test.go b/object/store/packed/internal/ingest/writepack_test.go
index 394d8f6e..d5ac969c 100644
--- a/object/store/packed/internal/ingest/writepack_test.go
+++ b/object/store/packed/internal/ingest/writepack_test.go
@@ -8,6 +8,8 @@ import (
 	"path/filepath"
 	"testing"
 
+	"lindenii.org/go/furgit/internal/format/packidx"
+	"lindenii.org/go/furgit/internal/format/packidx/bloom"
 	"lindenii.org/go/furgit/internal/testgit"
 	"lindenii.org/go/furgit/object/id"
 	"lindenii.org/go/furgit/object/store"
@@ -89,6 +91,77 @@ func TestWritePackMatchesGit(t *testing.T) {
 	}
 }
 
+// TestWritePackBloom verifies that ingesting a pack writes a Bloom filter
+// that reports every object in the pack as present.
+func TestWritePackBloom(t *testing.T) {
+	t.Parallel()
+
+	for _, objectFormat := range id.SupportedObjectFormats() {
+		t.Run(objectFormat.String(), func(t *testing.T) {
+			t.Parallel()
+
+			repo, err := testgit.NewRepo(t, testgit.RepoOptions{ObjectFormat: objectFormat})
+			if err != nil {
+				t.Fatalf("NewRepo: %v", err)
+			}
+
+			seeded, err := repo.SeedHistory(t)
+			if err != nil {
+				t.Fatalf("SeedHistory: %v", err)
+			}
+
+			gitPrefix, err := repo.PackObjects(t, seeded.All(), testgit.PackObjectsOptions{
+				RevIndex: true,
+				Revs:     false,
+				Exclude:  nil,
+			})
+			if err != nil {
+				t.Fatalf("PackObjects: %v", err)
+			}
+
+			stream, err := os.ReadFile(gitPrefix + ".pack") //nolint:gosec
+			if err != nil {
+				t.Fatalf("ReadFile pack: %v", err)
+			}
+
+			dir, result := writePack(t, objectFormat, bytes.NewReader(stream), store.PackWriteOptions{
+				ThinBase: nil,
+				Progress: nil,
+			})
+
+			if result.BloomName == "" {
+				t.Fatal("BloomName is empty")
+			}
+
+			bloomBytes, err := os.ReadFile(filepath.Join(dir, result.BloomName)) //nolint:gosec
+			if err != nil {
+				t.Fatalf("ReadFile bloom: %v", err)
+			}
+
+			filter, err := bloom.Parse(bloomBytes, objectFormat)
+			if err != nil {
+				t.Fatalf("bloom.Parse: %v", err)
+			}
+
+			idxBytes, err := os.ReadFile(filepath.Join(dir, result.IdxName)) //nolint:gosec
+			if err != nil {
+				t.Fatalf("ReadFile idx: %v", err)
+			}
+
+			index, err := packidx.Parse(idxBytes, objectFormat.Size())
+			if err != nil {
+				t.Fatalf("packidx.Parse: %v", err)
+			}
+
+			for pos := range index.NumObjects() {
+				if !filter.MayContain(index.OIDAt(pos)) {
+					t.Fatalf("filter rejects object at index position %d", pos)
+				}
+			}
+		})
+	}
+}
+
 // TestWritePackEmpty verifies that a zero-object pack
 // succeeds without writing any artifacts.
 func TestWritePackEmpty(t *testing.T) {