object/tree: Fix tests

1 files changed, 10 insertions, 31 deletions

diff --git a/object/tree/insert_test.go b/object/tree/insert_test.go
index fbf65b84..1dd406d5 100644
--- a/object/tree/insert_test.go
+++ b/object/tree/insert_test.go
@@ -18,10 +18,10 @@ func TestInsertRejects(t *testing.T) {
 		name  string
 		entry tree.Entry
 	}{
-		{name: "empty-name", entry: tree.Entry{Mode: mode.Regular, Name: "", ID: zero}},
-		{name: "slash-name", entry: tree.Entry{Mode: mode.Regular, Name: "a/b", ID: zero}},
-		{name: "nul-name", entry: tree.Entry{Mode: mode.Regular, Name: "a\x00b", ID: zero}},
-		{name: "invalid-mode", entry: tree.Entry{Mode: mode.Mode(0o100640), Name: "file", ID: zero}},
+		{name: "empty-name", entry: tree.Entry{Mode: mode.Regular, Name: []byte(""), ID: zero}},
+		{name: "slash-name", entry: tree.Entry{Mode: mode.Regular, Name: []byte("a/b"), ID: zero}},
+		{name: "nul-name", entry: tree.Entry{Mode: mode.Regular, Name: []byte("a\x00b"), ID: zero}},
+		{name: "invalid-mode", entry: tree.Entry{Mode: mode.Mode(0o100640), Name: []byte("file"), ID: zero}},
 	} {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
@@ -48,18 +48,18 @@ func TestInsertRejectsConflict(t *testing.T) {
 	}{
 		{
 			name:   "same-mode",
-			first:  tree.Entry{Mode: mode.Regular, Name: "file", ID: zero},
-			second: tree.Entry{Mode: mode.Regular, Name: "file", ID: zero},
+			first:  tree.Entry{Mode: mode.Regular, Name: []byte("file"), ID: zero},
+			second: tree.Entry{Mode: mode.Regular, Name: []byte("file"), ID: zero},
 		},
 		{
 			name:   "blob-then-tree",
-			first:  tree.Entry{Mode: mode.Regular, Name: "name", ID: zero},
-			second: tree.Entry{Mode: mode.Directory, Name: "name", ID: zero},
+			first:  tree.Entry{Mode: mode.Regular, Name: []byte("name"), ID: zero},
+			second: tree.Entry{Mode: mode.Directory, Name: []byte("name"), ID: zero},
 		},
 		{
 			name:   "tree-then-blob",
-			first:  tree.Entry{Mode: mode.Directory, Name: "name", ID: zero},
-			second: tree.Entry{Mode: mode.Regular, Name: "name", ID: zero},
+			first:  tree.Entry{Mode: mode.Directory, Name: []byte("name"), ID: zero},
+			second: tree.Entry{Mode: mode.Regular, Name: []byte("name"), ID: zero},
 		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {
@@ -79,24 +79,3 @@ func TestInsertRejectsConflict(t *testing.T) {
 		})
 	}
 }
-
-func TestEntriesIsCopy(t *testing.T) {
-	t.Parallel()
-
-	zero := id.SupportedObjectFormats()[0].Zero()
-
-	var tr tree.Tree
-
-	err := tr.Insert(tree.Entry{Mode: mode.Regular, Name: "file", ID: zero})
-	if err != nil {
-		t.Fatalf("Insert: %v", err)
-	}
-
-	entries := tr.Entries()
-	entries[0].Name = "mutated"
-
-	again := tr.Entries()
-	if again[0].Name != "file" {
-		t.Fatalf("Entries()[0].Name = %q, want %q", again[0].Name, "file")
-	}
-}