From 0eb5adaa6fda00b328c8a6242adb20a5bfeb6959 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sun, 29 Mar 2026 07:04:01 +0000 Subject: *: Remove Close exception for MT-Safe --- format/commitgraph/read/close.go | 2 ++ furgit.go | 3 +-- object/store/chain/close.go | 2 ++ object/store/loose/store.go | 2 ++ object/store/memory/store.go | 2 ++ object/store/mix/close.go | 2 ++ object/store/packed/close.go | 2 ++ object/store/reading.go | 2 ++ ref/store/chain/close.go | 2 ++ ref/store/files/close.go | 2 ++ ref/store/reading.go | 2 ++ 11 files changed, 21 insertions(+), 2 deletions(-) diff --git a/format/commitgraph/read/close.go b/format/commitgraph/read/close.go index d91c7762..c13b5f55 100644 --- a/format/commitgraph/read/close.go +++ b/format/commitgraph/read/close.go @@ -1,6 +1,8 @@ package read // Close releases all mapped commit-graph files. +// +// Labels: MT-Unsafe. func (reader *Reader) Close() error { var closeErr error diff --git a/furgit.go b/furgit.go index a43f6d40..4f57e70d 100644 --- a/furgit.go +++ b/furgit.go @@ -12,8 +12,7 @@ // // Concurrency labels: // -// - MT-Safe: safe for concurrent use, excluding Close unless documented -// otherwise. +// - MT-Safe: safe for concurrent use. // - MT-ReadSafe: safe for concurrent read-only use. // - MT-Unsafe: not safe for concurrent use without external synchronization. // diff --git a/object/store/chain/close.go b/object/store/chain/close.go index 403e178e..75fa357e 100644 --- a/object/store/chain/close.go +++ b/object/store/chain/close.go @@ -1,4 +1,6 @@ package chain // Close releases wrapper-local resources. +// +// Labels: MT-Unsafe. func (chain *Chain) Close() error { return nil } diff --git a/object/store/loose/store.go b/object/store/loose/store.go index ac9a4d99..ea466284 100644 --- a/object/store/loose/store.go +++ b/object/store/loose/store.go @@ -38,4 +38,6 @@ func New(root *os.Root, algo objectid.Algorithm) (*Store, error) { } // Close releases resources associated with the backend. +// +// Labels: MT-Unsafe. func (store *Store) Close() error { return nil } diff --git a/object/store/memory/store.go b/object/store/memory/store.go index bc6795ab..ff66da50 100644 --- a/object/store/memory/store.go +++ b/object/store/memory/store.go @@ -21,6 +21,8 @@ func New(algo objectid.Algorithm) *Store { } // Close closes the in-memory store. +// +// Labels: MT-Unsafe. func (store *Store) Close() error { return nil } diff --git a/object/store/mix/close.go b/object/store/mix/close.go index a614e586..51f7aa18 100644 --- a/object/store/mix/close.go +++ b/object/store/mix/close.go @@ -1,4 +1,6 @@ package mix // Close releases wrapper-local resources. +// +// Labels: MT-Unsafe. func (mix *Mix) Close() error { return nil } diff --git a/object/store/packed/close.go b/object/store/packed/close.go index 6c61e4e6..6ad31aac 100644 --- a/object/store/packed/close.go +++ b/object/store/packed/close.go @@ -1,6 +1,8 @@ package packed // Close releases mapped pack/index resources associated with the store. +// +// Labels: MT-Unsafe. func (store *Store) Close() error { store.stateMu.Lock() packs := store.packs diff --git a/object/store/reading.go b/object/store/reading.go index 9a487bcf..d27001bf 100644 --- a/object/store/reading.go +++ b/object/store/reading.go @@ -54,5 +54,7 @@ type ReadingStore interface { Refresh() error // Close releases resources associated with the backend. + // + // Labels: MT-Unsafe. Close() error } diff --git a/ref/store/chain/close.go b/ref/store/chain/close.go index 403e178e..75fa357e 100644 --- a/ref/store/chain/close.go +++ b/ref/store/chain/close.go @@ -1,4 +1,6 @@ package chain // Close releases wrapper-local resources. +// +// Labels: MT-Unsafe. func (chain *Chain) Close() error { return nil } diff --git a/ref/store/files/close.go b/ref/store/files/close.go index 0e5212d0..84a69dab 100644 --- a/ref/store/files/close.go +++ b/ref/store/files/close.go @@ -1,6 +1,8 @@ package files // Close releases resources associated with the store. +// +// Labels: MT-Unsafe. func (store *Store) Close() error { return store.commonRoot.Close() } diff --git a/ref/store/reading.go b/ref/store/reading.go index 66528127..99f8278c 100644 --- a/ref/store/reading.go +++ b/ref/store/reading.go @@ -34,5 +34,7 @@ type ReadingStore interface { // Close releases resources associated with the store. // // Transactions and batches borrowing the store are invalid after Close. + // + // Labels: MT-Unsafe. Close() error } -- cgit v1.3.1-10-gc9f91