From 784ad6c9e01da13e6f22cd58dae30aff2f1249d2 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sat, 7 Mar 2026 14:23:45 +0800 Subject: refstore: Rename Store to ReadingStore --- refstore/chain/chain.go | 2 +- refstore/chain/new.go | 4 ++-- refstore/loose/store.go | 2 +- refstore/packed/store.go | 2 +- refstore/refstore.go | 4 ++-- repository/refs.go | 6 +++--- repository/repository.go | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/refstore/chain/chain.go b/refstore/chain/chain.go index c20096d8..882d4b56 100644 --- a/refstore/chain/chain.go +++ b/refstore/chain/chain.go @@ -6,5 +6,5 @@ import "codeberg.org/lindenii/furgit/refstore" // Chain queries multiple reference stores in order. type Chain struct { - backends []refstore.Store + backends []refstore.ReadingStore } diff --git a/refstore/chain/new.go b/refstore/chain/new.go index 8ea9b46c..ebf5e2bb 100644 --- a/refstore/chain/new.go +++ b/refstore/chain/new.go @@ -3,8 +3,8 @@ package chain import "codeberg.org/lindenii/furgit/refstore" // New creates an ordered reference store chain. -func New(backends ...refstore.Store) *Chain { +func New(backends ...refstore.ReadingStore) *Chain { return &Chain{ - backends: append([]refstore.Store(nil), backends...), + backends: append([]refstore.ReadingStore(nil), backends...), } } diff --git a/refstore/loose/store.go b/refstore/loose/store.go index ebe6cc60..081e3718 100644 --- a/refstore/loose/store.go +++ b/refstore/loose/store.go @@ -18,7 +18,7 @@ type Store struct { algo objectid.Algorithm } -var _ refstore.Store = (*Store)(nil) +var _ refstore.ReadingStore = (*Store)(nil) // New creates a loose ref store rooted at a repository root. func New(root *os.Root, algo objectid.Algorithm) (*Store, error) { diff --git a/refstore/packed/store.go b/refstore/packed/store.go index 92f69ec6..724427ab 100644 --- a/refstore/packed/store.go +++ b/refstore/packed/store.go @@ -12,4 +12,4 @@ type Store struct { ordered []ref.Detached } -var _ refstore.Store = (*Store)(nil) +var _ refstore.ReadingStore = (*Store)(nil) diff --git a/refstore/refstore.go b/refstore/refstore.go index ba9141b9..b9760ecf 100644 --- a/refstore/refstore.go +++ b/refstore/refstore.go @@ -11,8 +11,8 @@ import ( // TODO: Interface error? Just like object not found in objectstore. var ErrReferenceNotFound = errors.New("refstore: reference not found") -// Store reads Git references. -type Store interface { +// ReadingStore reads Git references. +type ReadingStore interface { // Resolve resolves a reference name to either a symbolic or detached ref. // // Implementations should return value forms (ref.Detached or ref.Symbolic), diff --git a/repository/refs.go b/repository/refs.go index f3ce6435..fb2256df 100644 --- a/repository/refs.go +++ b/repository/refs.go @@ -13,7 +13,7 @@ import ( ) //nolint:ireturn -func openRefStore(root *os.Root, algo objectid.Algorithm) (out refstore.Store, err error) { +func openRefStore(root *os.Root, algo objectid.Algorithm) (out refstore.ReadingStore, err error) { looseRoot, err := root.OpenRoot(".") if err != nil { return nil, fmt.Errorf("repository: open root for loose refs: %w", err) @@ -26,7 +26,7 @@ func openRefStore(root *os.Root, algo objectid.Algorithm) (out refstore.Store, e return nil, err } - backends := []refstore.Store{looseStore} + backends := []refstore.ReadingStore{looseStore} _, err = root.Stat("packed-refs") if err == nil { @@ -50,6 +50,6 @@ func openRefStore(root *os.Root, algo objectid.Algorithm) (out refstore.Store, e // Refs returns the configured ref store. // //nolint:ireturn -func (repo *Repository) Refs() refstore.Store { +func (repo *Repository) Refs() refstore.ReadingStore { return repo.refs } diff --git a/repository/repository.go b/repository/repository.go index aeb048bd..7948f2ee 100644 --- a/repository/repository.go +++ b/repository/repository.go @@ -19,5 +19,5 @@ type Repository struct { objects objectstore.Store objectsLooseForWritingOnly *objectloose.Store - refs refstore.Store + refs refstore.ReadingStore } -- cgit v1.3.1-10-gc9f91