From e7156cfb1df3302c333d9e8add3921f280a3d0e1 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sun, 14 Jun 2026 01:51:59 +0000 Subject: *: Preallocate slices --- internal/format/packidx/write.go | 2 +- internal/testgit/tree.go | 2 +- object/store/packed/internal/ingest/resolve.go | 2 +- object/store/packed/internal/ingest/thin.go | 2 +- object/store/packed/refresh.go | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/format/packidx/write.go b/internal/format/packidx/write.go index d3f22c83..35b2805f 100644 --- a/internal/format/packidx/write.go +++ b/internal/format/packidx/write.go @@ -84,7 +84,7 @@ func Write(w io.Writer, objectFormat id.ObjectFormat, entries []Entry, packHash sw.PutUint32(entries[i].CRC32) } - var largeOffsets []uint64 + largeOffsets := make([]uint64, 0, len(entries)) for i := range entries { offset := entries[i].Offset diff --git a/internal/testgit/tree.go b/internal/testgit/tree.go index 501c7949..ff9b1918 100644 --- a/internal/testgit/tree.go +++ b/internal/testgit/tree.go @@ -50,7 +50,7 @@ func (repo *Repo) LsTree(tb testing.TB, oid id.ObjectID) ([]TreeEntry, error) { return nil, fmt.Errorf("ls-tree: %w", err) } - var entries []TreeEntry + entries := make([]TreeEntry, 0, bytes.Count(stdout, []byte{0})) for record := range bytes.SplitSeq(stdout, []byte{0}) { if len(record) == 0 { diff --git a/object/store/packed/internal/ingest/resolve.go b/object/store/packed/internal/ingest/resolve.go index 8595d366..77b0fa0f 100644 --- a/object/store/packed/internal/ingest/resolve.go +++ b/object/store/packed/internal/ingest/resolve.go @@ -270,7 +270,7 @@ func (ingestion *ingestion) countUnresolved() int { func (ingestion *ingestion) unresolvedExternalBases() []id.ObjectID { seen := make(map[id.ObjectID]struct{}) - var out []id.ObjectID + out := make([]id.ObjectID, 0, ingestion.deltaCount-ingestion.deltasResolved) for index := range ingestion.records { rec := &ingestion.records[index] diff --git a/object/store/packed/internal/ingest/thin.go b/object/store/packed/internal/ingest/thin.go index 8d1566e0..fa125f2f 100644 --- a/object/store/packed/internal/ingest/thin.go +++ b/object/store/packed/internal/ingest/thin.go @@ -33,7 +33,7 @@ func (ingestion *ingestion) fixThin(external []id.ObjectID, adjacency adjacency, // Drop the trailer from the write cursor. ingestion.scanner.consumed -= hashSize - var appended []int + appended := make([]int, 0, len(external)) for _, baseOID := range external { ty, content, err := ingestion.opts.ThinBase.ReadBytesContent(baseOID) diff --git a/object/store/packed/refresh.go b/object/store/packed/refresh.go index 14c66013..f06e9859 100644 --- a/object/store/packed/refresh.go +++ b/object/store/packed/refresh.go @@ -23,7 +23,7 @@ func (packed *Packed) Refresh() error { next := make(map[string]*pack, len(packed.byName)) - var opened []*pack + opened := make([]*pack, 0, len(dirEntries)) for _, dirEntry := range dirEntries { name, ok := strings.CutSuffix(dirEntry.Name(), ".idx") -- cgit v1.3.1-10-gc9f91