From ffb98db8fbcdae9332392aabb2bdd217795c0432 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sun, 7 Jun 2026 06:14:54 +0000 Subject: More cleanups --- config/config.go | 1 - config/doc.go | 3 +++ config/lookup.go | 24 ++++++++++++------------ 3 files changed, 15 insertions(+), 13 deletions(-) create mode 100644 config/doc.go (limited to 'config') diff --git a/config/config.go b/config/config.go index 35e0ea09..523edaf8 100644 --- a/config/config.go +++ b/config/config.go @@ -1,4 +1,3 @@ -// Package config provides configuration parsing. package config import ( diff --git a/config/doc.go b/config/doc.go new file mode 100644 index 00000000..c2116c36 --- /dev/null +++ b/config/doc.go @@ -0,0 +1,3 @@ +// Package config parses Git configuration files +// and provides typed lookup of their values. +package config diff --git a/config/lookup.go b/config/lookup.go index ede2026e..33c72ac7 100644 --- a/config/lookup.go +++ b/config/lookup.go @@ -11,10 +11,10 @@ type LookupResult struct { } // String returns the explicit string value. -func (r LookupResult) String() (string, error) { - switch r.Kind { +func (result LookupResult) String() (string, error) { + switch result.Kind { case KindString: - return r.Value, nil + return result.Value, nil case KindValueless: return "", ErrValueless case KindMissing: @@ -25,10 +25,10 @@ func (r LookupResult) String() (string, error) { } // Bool interprets this lookup result using Git config boolean rules. -func (r LookupResult) Bool() (bool, error) { - switch r.Kind { +func (result LookupResult) Bool() (bool, error) { + switch result.Kind { case KindString: - return parseBool(r.Value) + return parseBool(result.Value) case KindValueless: return true, nil case KindMissing: @@ -39,10 +39,10 @@ func (r LookupResult) Bool() (bool, error) { } // Int interprets this lookup result as a Git integer value. -func (r LookupResult) Int() (int, error) { - switch r.Kind { +func (result LookupResult) Int() (int, error) { + switch result.Kind { case KindString: - return parseInt(r.Value) + return parseInt(result.Value) case KindValueless: return 0, ErrValueless case KindMissing: @@ -53,10 +53,10 @@ func (r LookupResult) Int() (int, error) { } // Int64 interprets this lookup result as a Git int64 value. -func (r LookupResult) Int64() (int64, error) { - switch r.Kind { +func (result LookupResult) Int64() (int64, error) { + switch result.Kind { case KindString: - return parseInt64(r.Value) + return parseInt64(result.Value) case KindValueless: return 0, ErrValueless case KindMissing: -- cgit v1.3.1-10-gc9f91