From 355f5b3dc9ae560827cd274e113f43d09ee9ac49 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Thu, 5 Mar 2026 21:09:07 +0800 Subject: *: Fix overflows --- internal/compress/zlib/reader.go | 17 +++++++++++++++-- internal/compress/zlib/reader_reset.go | 19 +++++++++++++++++-- 2 files changed, 32 insertions(+), 4 deletions(-) (limited to 'internal/compress') diff --git a/internal/compress/zlib/reader.go b/internal/compress/zlib/reader.go index a6497dec..f298a07f 100644 --- a/internal/compress/zlib/reader.go +++ b/internal/compress/zlib/reader.go @@ -41,6 +41,7 @@ import ( "sync" "codeberg.org/lindenii/furgit/internal/compress/flate" + "codeberg.org/lindenii/furgit/internal/intconv" ) const ( @@ -131,7 +132,14 @@ func (z *Reader) Read(p []byte) (int, error) { // Finished file; check checksum. readN, err := io.ReadFull(z.r, z.scratch[0:4]) - z.trailerRead += uint64(readN) + readNUint64, convErr := intconv.IntToUint64(readN) + if convErr != nil { + z.err = convErr + + return n, z.err + } + + z.trailerRead += readNUint64 if err != nil { if errors.Is(err, io.EOF) { @@ -160,7 +168,12 @@ func (z *Reader) Read(p []byte) (int, error) { func (z *Reader) InputConsumed() uint64 { out := z.headerRead + z.trailerRead if z.progress != nil { - out += uint64(z.progress.InputConsumed()) + progressIn, err := intconv.Int64ToUint64(z.progress.InputConsumed()) + if err != nil { + panic(err) + } + + out += progressIn } return out diff --git a/internal/compress/zlib/reader_reset.go b/internal/compress/zlib/reader_reset.go index 32af0b49..3e78ab5d 100644 --- a/internal/compress/zlib/reader_reset.go +++ b/internal/compress/zlib/reader_reset.go @@ -12,6 +12,7 @@ import ( "codeberg.org/lindenii/furgit/internal/adler32" "codeberg.org/lindenii/furgit/internal/compress/flate" + "codeberg.org/lindenii/furgit/internal/intconv" ) // reset resets receiver to read a new zlib stream. @@ -29,7 +30,14 @@ func (z *Reader) reset(r io.Reader, dict []byte) error { // Read the header (RFC 1950 section 2.2.). readN, err := io.ReadFull(z.r, z.scratch[0:2]) - z.headerRead += uint64(readN) + readNUint64, convErr := intconv.IntToUint64(readN) + if convErr != nil { + z.err = convErr + + return z.err + } + + z.headerRead += readNUint64 z.err = err if z.err != nil { @@ -51,7 +59,14 @@ func (z *Reader) reset(r io.Reader, dict []byte) error { if haveDict { readN, z.err = io.ReadFull(z.r, z.scratch[0:4]) - z.headerRead += uint64(readN) + readNUint64, err := intconv.IntToUint64(readN) + if err != nil { + z.err = err + + return z.err + } + + z.headerRead += readNUint64 if z.err != nil { if errors.Is(z.err, io.EOF) { z.err = io.ErrUnexpectedEOF -- cgit v1.3.1-10-gc9f91