From 82bc1cd67431d11690217813192ccc1510ce378b Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sun, 22 Mar 2026 14:00:14 +0000 Subject: internal/testgit: why not make it more annoying to use ambient authority --- internal/testgit/repo_properties.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'internal/testgit') diff --git a/internal/testgit/repo_properties.go b/internal/testgit/repo_properties.go index e99281ec..b731a6e4 100644 --- a/internal/testgit/repo_properties.go +++ b/internal/testgit/repo_properties.go @@ -12,9 +12,9 @@ func (testRepo *TestRepo) Env() []string { return append([]string(nil), testRepo.env...) } -// DirButYouShouldReallyNotUseThisOkay returns the git dir of a repo. +// DirButYouShouldReallyNotUseThisYouShouldReallyConsiderUsingAProperCapabilityInterfaceInsteadAndIAmKeepingThisMethodIntentionallyLongToAnnoyYou returns the git dir of a repo. // Consider using a properly capability interface such as // os.Root instead; all uses of ambient path authority must be justified. -func (testRepo *TestRepo) DirButYouShouldReallyNotUseThisOkay() string { +func (testRepo *TestRepo) DirButYouShouldReallyNotUseThisYouShouldReallyConsiderUsingAProperCapabilityInterfaceInsteadAndIAmKeepingThisMethodIntentionallyLongToAnnoyYou() string { return testRepo.dir } -- cgit v1.3.1-10-gc9f91