From 22f7dcbf39e064de83ba56ed2aaf20bd64b239aa Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Mon, 30 Mar 2026 06:00:15 +0000 Subject: object/tree: Why wasn't I binary searching for remove --- object/tree/insert.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'object/tree/insert.go') diff --git a/object/tree/insert.go b/object/tree/insert.go index 683af4a7..22bda74f 100644 --- a/object/tree/insert.go +++ b/object/tree/insert.go @@ -15,11 +15,8 @@ func (tree *Tree) InsertEntry(newEntry TreeEntry) error { newEntry.Name = append([]byte(nil), newEntry.Name...) - insertAt, _ := slices.BinarySearchFunc(tree.Entries, treeEntrySearch{ - name: newEntry.Name, - isTree: newEntry.Mode == FileModeDir, - }, func(entry TreeEntry, search treeEntrySearch) int { - return TreeEntryNameCompare(entry.Name, entry.Mode, search.name, search.isTree) + insertAt, _ := slices.BinarySearchFunc(tree.Entries, newEntry.Name, func(entry TreeEntry, name []byte) int { + return TreeEntryNameCompare(entry.Name, entry.Mode, name, newEntry.Mode == FileModeDir) }) tree.Entries = slices.Insert(tree.Entries, insertAt, newEntry) -- cgit v1.3.1-10-gc9f91