From 22f7dcbf39e064de83ba56ed2aaf20bd64b239aa Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Mon, 30 Mar 2026 06:00:15 +0000 Subject: object/tree: Why wasn't I binary searching for remove --- object/tree/remove.go | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'object/tree/remove.go') diff --git a/object/tree/remove.go b/object/tree/remove.go index 9a099842..94de88da 100644 --- a/object/tree/remove.go +++ b/object/tree/remove.go @@ -1,7 +1,6 @@ package tree import ( - "bytes" "fmt" "slices" ) @@ -12,14 +11,12 @@ func (tree *Tree) RemoveEntry(name []byte) error { return fmt.Errorf("object: tree: entry %q not found", name) } - index := slices.IndexFunc(tree.Entries, func(entry TreeEntry) bool { - return bytes.Equal(entry.Name, name) - }) - if index >= 0 { - tree.Entries = slices.Delete(tree.Entries, index, index+1) - - return nil + index, ok := tree.entryIndex(name) + if !ok { + return fmt.Errorf("object: tree: entry %q not found", name) } - return fmt.Errorf("object: tree: entry %q not found", name) + tree.Entries = slices.Delete(tree.Entries, index, index+1) + + return nil } -- cgit v1.3.1-10-gc9f91