From f84f3a3c79b09ad13fdc826933c4c1d8353cdefb Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sun, 24 May 2026 08:16:38 +0000 Subject: object{,/blob,/commit}: Fix lints --- object/blob/parse.go | 2 +- object/commit/append.go | 1 - object/parse.go | 8 +++----- 3 files changed, 4 insertions(+), 7 deletions(-) (limited to 'object') diff --git a/object/blob/parse.go b/object/blob/parse.go index b98b0f14..b5522e6a 100644 --- a/object/blob/parse.go +++ b/object/blob/parse.go @@ -2,7 +2,7 @@ package blob // Parse decodes a blob object body. // -// Labels: Deps-Owned, Life-Independent +// Labels: Deps-Owned, Life-Independent. func Parse(body []byte) (*Blob, error) { return &Blob{Data: append([]byte(nil), body...)}, nil } diff --git a/object/commit/append.go b/object/commit/append.go index 2bc00573..31031ed1 100644 --- a/object/commit/append.go +++ b/object/commit/append.go @@ -31,7 +31,6 @@ func (commit *Commit) AppendWithoutHeader(dst []byte) ([]byte, error) { for _, h := range commit.ExtraHeaders { // GIGO on empty keys and such. - dst = append(dst, []byte(h.Key)...) dst = append(dst, byte(' ')) dst = append(dst, h.Value...) diff --git a/object/parse.go b/object/parse.go index a4d0d350..6fbaa9b9 100644 --- a/object/parse.go +++ b/object/parse.go @@ -8,15 +8,13 @@ import ( "codeberg.org/lindenii/furgit/object/header" "codeberg.org/lindenii/furgit/object/id" "codeberg.org/lindenii/furgit/object/typ" - // "codeberg.org/lindenii/furgit/object/tag" - // "codeberg.org/lindenii/furgit/object/tree" ) // SizeMismatchError indicates a mismatch // between the size expected from the object header // and the size of the object. type SizeMismatchError struct { - Expected int + Expected uint64 Got int } @@ -34,12 +32,12 @@ func (sizeMismatchError SizeMismatchError) Error() string { func ParseWithHeader(raw []byte, algo id.Algorithm) (Object, error) { ty, size, headerLen, err := header.Parse(raw) if err != nil { - return nil, err + return nil, err //nolint:wrapcheck } body := raw[headerLen:] if uint64(len(body)) != size { - return nil, SizeMismatchError{Expected: int(size), Got: len(body)} + return nil, SizeMismatchError{Expected: size, Got: len(body)} } return ParseWithoutHeader(ty, body, algo) -- cgit v1.3.1-10-gc9f91