From 1de28c5fc4331ed3841661246be167c450ff7986 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Mon, 17 Nov 2025 00:00:00 +0000 Subject: Revert "Compute checksum when reading packfiles" This reverts commit 1dcb92427c23d0a8b23c0154b892243c749afa5a. Yeah this should be part of the network protocol rather than being done on *every read*. --- pack_idx.go | 17 ----------------- 1 file changed, 17 deletions(-) (limited to 'pack_idx.go') diff --git a/pack_idx.go b/pack_idx.go index a9cb9056..68170ad3 100644 --- a/pack_idx.go +++ b/pack_idx.go @@ -196,23 +196,6 @@ func (pi *packIndex) parse(buf []byte) error { pi.numObjects = nobj pi.names = buf[namesStart:namesEnd] pi.crcs = buf[crcStart:crcEnd] - - if len(buf) < 2*pi.repo.hashSize { - return ErrInvalidObject - } - idxChecksumStart := len(buf) - pi.repo.hashSize - idxChecksumInFile := buf[idxChecksumStart:] - - hashFn, ok := hashFuncs[pi.repo.hashSize] - if !ok { - return fmt.Errorf("furgit: unsupported hash size %d", pi.repo.hashSize) - } - - computedHash := hashFn(buf[:idxChecksumStart]) - if !bytes.Equal(computedHash.data[:pi.repo.hashSize], idxChecksumInFile) { - return fmt.Errorf("furgit: index checksum mismatch in %s", pi.idxRel) - } - return nil } -- cgit v1.3.1-10-gc9f91