From 1de28c5fc4331ed3841661246be167c450ff7986 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Mon, 17 Nov 2025 00:00:00 +0000 Subject: Revert "Compute checksum when reading packfiles" This reverts commit 1dcb92427c23d0a8b23c0154b892243c749afa5a. Yeah this should be part of the network protocol rather than being done on *every read*. --- pack_midx.go | 18 ------------------ 1 file changed, 18 deletions(-) (limited to 'pack_midx.go') diff --git a/pack_midx.go b/pack_midx.go index 04151dfe..748bdaf6 100644 --- a/pack_midx.go +++ b/pack_midx.go @@ -1,7 +1,6 @@ package furgit import ( - "bytes" "fmt" "os" "path/filepath" @@ -236,23 +235,6 @@ func (midx *multiPackIndex) parse(buf []byte) error { midx.oids = oids midx.offsets = offsets midx.largeOffs = largeOffs - - if len(buf) < midx.repo.hashSize { - return ErrInvalidObject - } - midxChecksumStart := len(buf) - midx.repo.hashSize - midxChecksumInFile := buf[midxChecksumStart:] - - hashFn, ok := hashFuncs[midx.repo.hashSize] - if !ok { - return fmt.Errorf("furgit: unsupported hash size %d", midx.repo.hashSize) - } - - computedHash := hashFn(buf[:midxChecksumStart]) - if !bytes.Equal(computedHash.data[:midx.repo.hashSize], midxChecksumInFile) { - return fmt.Errorf("furgit: multi-pack-index checksum mismatch") - } - return nil } -- cgit v1.3.1-10-gc9f91