From 474bcba13eddb1ae2fb2fa6340f1c4064cdcf12f Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sat, 7 Mar 2026 00:38:50 +0800 Subject: *: Use errors.AsType --- reachability/integration_test.go | 4 ++-- reachability/unit_test.go | 8 ++++---- reachability/walk_expand_commits_graph.go | 3 +-- 3 files changed, 7 insertions(+), 8 deletions(-) (limited to 'reachability') diff --git a/reachability/integration_test.go b/reachability/integration_test.go index 6b043d92..feda699b 100644 --- a/reachability/integration_test.go +++ b/reachability/integration_test.go @@ -187,8 +187,8 @@ func TestCheckConnectedMissingObject(t *testing.T) { t.Fatal("expected error") } - var missing *giterrors.ObjectMissingError - if !errors.As(err, &missing) { + missing, ok := errors.AsType[*giterrors.ObjectMissingError](err) + if !ok { t.Fatalf("expected ObjectMissingError, got %T (%v)", err, err) } diff --git a/reachability/unit_test.go b/reachability/unit_test.go index dea6d38b..1a2f4773 100644 --- a/reachability/unit_test.go +++ b/reachability/unit_test.go @@ -164,8 +164,8 @@ func TestWalkDomainCommitsRejectsNonCommitRootAfterPeel(t *testing.T) { t.Fatal("expected error") } - var typeErr *giterrors.ObjectTypeError - if !errors.As(err, &typeErr) { + typeErr, ok := errors.AsType[*giterrors.ObjectTypeError](err) + if !ok { t.Fatalf("expected ObjectTypeError, got %T (%v)", err, err) } @@ -280,8 +280,8 @@ func TestCheckConnectedReturnsConcreteMissingObject(t *testing.T) { t.Fatal("expected error") } - var missing *giterrors.ObjectMissingError - if !errors.As(err, &missing) { + missing, ok := errors.AsType[*giterrors.ObjectMissingError](err) + if !ok { t.Fatalf("expected ObjectMissingError, got %T (%v)", err, err) } diff --git a/reachability/walk_expand_commits_graph.go b/reachability/walk_expand_commits_graph.go index 90e52112..9602f35c 100644 --- a/reachability/walk_expand_commits_graph.go +++ b/reachability/walk_expand_commits_graph.go @@ -11,8 +11,7 @@ import ( func (walk *Walk) expandCommitsFromGraph(id objectid.ObjectID) ([]walkItem, bool, error) { pos, err := walk.reachability.graph.Lookup(id) if err != nil { - var notFound *commitgraphread.NotFoundError - if errors.As(err, ¬Found) { + if _, ok := errors.AsType[*commitgraphread.NotFoundError](err); ok { return nil, false, nil } -- cgit v1.3.1-10-gc9f91