From 5d68b08dcd50c65e6e67239ca1ee8b25786d4559 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Wed, 20 May 2026 16:27:38 +0000 Subject: ref/store: More bikeshedding --- ref/store/errors.go | 1 + ref/store/update_errors.go | 3 +++ 2 files changed, 4 insertions(+) (limited to 'ref') diff --git a/ref/store/errors.go b/ref/store/errors.go index 45583440..3b2b15b3 100644 --- a/ref/store/errors.go +++ b/ref/store/errors.go @@ -4,4 +4,5 @@ import "errors" // ErrReferenceNotFound indicates that a reference does not exist in a backend. // TODO: Interface error? Just like object not found in objectstore. +// I'm not sure if I want this as a sentinel. var ErrReferenceNotFound = errors.New("refstore: reference not found") diff --git a/ref/store/update_errors.go b/ref/store/update_errors.go index f05f37d2..d3580439 100644 --- a/ref/store/update_errors.go +++ b/ref/store/update_errors.go @@ -62,6 +62,9 @@ func (err *CreateExistsError) Error() string { // IncorrectOldValueError indicates that one operation's expected old value did // not match the current reference value. +// +// TODO: All of these errors should be redesigned. +// Strings are not appropriate here. type IncorrectOldValueError struct { Actual string Expected string -- cgit v1.3.1-10-gc9f91