From f50ac551c56569e109a8350f27dab53bb2378d4d Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sun, 29 Mar 2026 15:43:50 +0000 Subject: *: Remove Close from object/ref store interfaces At places where you own the object, you should have the literal implementation with Close. If you're using it via the interface, then you probably don't own that store, and you shouldn't be closing it. Thanks to Michael Muré from git-bug for this point. --- repository/objects.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'repository/objects.go') diff --git a/repository/objects.go b/repository/objects.go index 62170514..2e63ad65 100644 --- a/repository/objects.go +++ b/repository/objects.go @@ -81,7 +81,7 @@ func openObjectStore( // bytes, or streamed object contents. Callers who want typed object values // should usually prefer [Repository.Fetcher]. // -// Labels: Life-Parent, Close-No. +// Labels: Life-Parent. // //nolint:ireturn func (repo *Repository) Objects() objectstore.ReadingStore { -- cgit v1.3.1-10-gc9f91