From f50ac551c56569e109a8350f27dab53bb2378d4d Mon Sep 17 00:00:00 2001
From: Runxi Yu
Date: Sun, 29 Mar 2026 15:43:50 +0000
Subject: *: Remove Close from object/ref store interfaces

At places where you own the object, you should have the literal
implementation with Close. If you're using it via the interface, then
you probably don't own that store, and you shouldn't be closing it.

Thanks to Michael Muré from git-bug for this point.
---
 repository/close.go   | 14 --------------
 repository/objects.go |  2 +-
 repository/refs.go    |  2 +-
 3 files changed, 2 insertions(+), 16 deletions(-)

(limited to 'repository')

diff --git a/repository/close.go b/repository/close.go
index 5d728c5b..c1261821 100644
--- a/repository/close.go
+++ b/repository/close.go
@@ -8,20 +8,6 @@ import "errors"
 func (repo *Repository) Close() error {
 	var errs []error
 
-	if repo.refs != nil {
-		err := repo.refs.Close()
-		if err != nil {
-			errs = append(errs, err)
-		}
-	}
-
-	if repo.objects != nil {
-		err := repo.objects.Close()
-		if err != nil {
-			errs = append(errs, err)
-		}
-	}
-
 	if repo.commitGraph != nil {
 		err := repo.commitGraph.Close()
 		if err != nil {
diff --git a/repository/objects.go b/repository/objects.go
index 62170514..2e63ad65 100644
--- a/repository/objects.go
+++ b/repository/objects.go
@@ -81,7 +81,7 @@ func openObjectStore(
 // bytes, or streamed object contents. Callers who want typed object values
 // should usually prefer [Repository.Fetcher].
 //
-// Labels: Life-Parent, Close-No.
+// Labels: Life-Parent.
 //
 //nolint:ireturn
 func (repo *Repository) Objects() objectstore.ReadingStore {
diff --git a/repository/refs.go b/repository/refs.go
index 0403e001..17816168 100644
--- a/repository/refs.go
+++ b/repository/refs.go
@@ -8,7 +8,7 @@ import refstore "codeberg.org/lindenii/furgit/ref/store"
 // A common pattern is to resolve a reference first and then pass the resulting
 // object ID to [Repository.Fetcher] or [Repository.Objects].
 //
-// Labels: Life-Parent, Close-No.
+// Labels: Life-Parent.
 //
 //nolint:ireturn
 func (repo *Repository) Refs() refstore.ReadWriteStore {
-- 
cgit v1.3.1-10-gc9f91