diff options
| author |  danieldg | 2009-09-02 00:43:04 +0000 |
|---|---|---|
| committer | danieldg | 2009-09-02 00:43:04 +0000 |
| commit | 2630a87bb13b089e6d0fdcff4bcd0f3a9612e52f (patch) | |
| tree | 8a780298dbc1311024047a2587fddcd0beafd2ca /src/modules/m_svshold.cpp | |
| parent | Clean up challenge generation to not include character 0x7F, and fix some oth... (diff) | |
Change allocation of commands/modes
API change: Commands passed to AddCommand are no longer deleted automatically
This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7
Diffstat (limited to 'src/modules/m_svshold.cpp')
| -rw-r--r-- | src/modules/m_svshold.cpp | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/src/modules/m_svshold.cpp b/src/modules/m_svshold.cpp index 08ba21108..ada7fbc68 100644 --- a/src/modules/m_svshold.cpp +++ b/src/modules/m_svshold.cpp @@ -142,17 +142,15 @@ class CommandSvshold : public Command class ModuleSVSHold : public Module { - CommandSvshold *mycommand; - SVSHoldFactory *s; + CommandSvshold cmd; + SVSHoldFactory s; public: - ModuleSVSHold(InspIRCd* Me) : Module(Me) + ModuleSVSHold(InspIRCd* Me) : Module(Me), cmd(Me), s(Me) { - s = new SVSHoldFactory(ServerInstance); - ServerInstance->XLines->RegisterFactory(s); - mycommand = new CommandSvshold(Me); - ServerInstance->AddCommand(mycommand); + ServerInstance->XLines->RegisterFactory(&s); + ServerInstance->AddCommand(&cmd); Implementation eventlist[] = { I_OnUserPreNick, I_OnSyncOtherMetaData, I_OnDecodeMetaData, I_OnStats }; ServerInstance->Modules->Attach(eventlist, this, 4); } @@ -183,7 +181,7 @@ class ModuleSVSHold : public Module virtual ~ModuleSVSHold() { ServerInstance->XLines->DelAll("SVSHOLD"); - ServerInstance->XLines->UnregisterFactory(s); + ServerInstance->XLines->UnregisterFactory(&s); } virtual Version GetVersion() |