diff options
| author |  danieldg | 2010-03-02 03:23:18 +0000 |
|---|---|---|
| committer |  Daniel De Graaf | 2010-08-03 17:32:38 -0400 |
| commit | 5401cc3c46ec9beacef2640ea10291bfa0d019cb (patch) | |
| tree | 58c3b3e9c17e68b3db5235fdac0c51ac8426b060 /src/modules | |
| parent | DelFd should not fail, it will leave a bad dangling pointer in that case (diff) | |
Fix some more incorrect socket use
Diffstat (limited to 'src/modules')
| -rw-r--r-- | src/modules/extra/m_pgsql.cpp | 12 | ||||
| -rw-r--r-- | src/modules/m_ident.cpp | 1 | ||||
| -rw-r--r-- | src/modules/m_spanningtree/rsquit.cpp | 1 |
3 files changed, 1 insertions, 13 deletions
diff --git a/src/modules/extra/m_pgsql.cpp b/src/modules/extra/m_pgsql.cpp index 629193ea1..b1f6916d0 100644 --- a/src/modules/extra/m_pgsql.cpp +++ b/src/modules/extra/m_pgsql.cpp @@ -735,17 +735,7 @@ class SQLConn : public EventHandler void Close() { - if (!ServerInstance->SE->DelFd(this)) - { - if (sql && PQstatus(sql) == CONNECTION_BAD) - { - ServerInstance->SE->DelFd(this, true); - } - else - { - ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: PQsocket cant be removed from socket engine!"); - } - } + ServerInstance->SE->DelFd(this); if(sql) { diff --git a/src/modules/m_ident.cpp b/src/modules/m_ident.cpp index 9f4ca2fef..734dac944 100644 --- a/src/modules/m_ident.cpp +++ b/src/modules/m_ident.cpp @@ -189,7 +189,6 @@ class IdentRequestSocket : public EventHandler ServerInstance->Logs->Log("m_ident",DEBUG,"Close ident socket %d", GetFd()); ServerInstance->SE->DelFd(this); ServerInstance->SE->Close(GetFd()); - ServerInstance->SE->Shutdown(GetFd(), SHUT_WR); this->SetFd(-1); } } diff --git a/src/modules/m_spanningtree/rsquit.cpp b/src/modules/m_spanningtree/rsquit.cpp index 39378c31d..d285520f9 100644 --- a/src/modules/m_spanningtree/rsquit.cpp +++ b/src/modules/m_spanningtree/rsquit.cpp @@ -57,7 +57,6 @@ CmdResult CommandRSQuit::Handle (const std::vector<std::string>& parameters, Use const char *reason = parameters.size() == 2 ? parameters[1].c_str() : "No reason"; ServerInstance->SNO->WriteToSnoMask('l',"RSQUIT: Server \002%s\002 removed from network by %s (%s)", parameters[0].c_str(), user->nick.c_str(), reason); sock->Squit(server_target, std::string("Server quit by ") + user->GetFullRealHost() + " (" + reason + ")"); - ServerInstance->SE->DelFd(sock); sock->Close(); } } |