diff options
| author |  Sadie Powell | 2025-02-27 22:47:27 +0000 |
|---|---|---|
| committer | Sadie Powell | 2025-02-27 22:56:38 +0000 |
| commit | 98397935cb5eefc2d8ac07b1b58dc700dc2406eb (patch) | |
| tree | 4a12c0d3c104c8195c285401af32bdf050444ae4 /src/modules | |
| parent | Error if a user doesn't specify any DNSBL records to match. (diff) | |
| download | inspircd++-98397935cb5eefc2d8ac07b1b58dc700dc2406eb.tar.gz inspircd++-98397935cb5eefc2d8ac07b1b58dc700dc2406eb.tar.bz2 inspircd++-98397935cb5eefc2d8ac07b1b58dc700dc2406eb.zip | |
Deprecate bitmask DNSBL records.
We don't use these in any of our docs or example configs and almost
everyone uses the record type. Using a bitmask is also a source of
footguns because users don't really understand how bit masks
actually work.
Diffstat (limited to 'src/modules')
| -rw-r--r-- | src/modules/m_dnsbl.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/modules/m_dnsbl.cpp b/src/modules/m_dnsbl.cpp index 9821d3bc6..58f1eee23 100644 --- a/src/modules/m_dnsbl.cpp +++ b/src/modules/m_dnsbl.cpp @@ -139,13 +139,16 @@ public: { "zline", Action::ZLINE }, }); - const std::string typestr = tag->getString("type"); + const std::string typestr = tag->getString("type", "record", 1); if (insp::equalsci(typestr, "bitmask")) { type = Type::BITMASK; bitmask = tag->getNum<unsigned int>("bitmask", 0); records = 0; + + ServerInstance->Logs.Normal(MODNAME, "<dnsbl> tag at {} specifies a bitmask. This is deprecated and will be removed in the next major version of InspIRCd, consider migrating to records instead.", + tag->source.str()); } else if (insp::equalsci(typestr, "record")) { |