summaryrefslogtreecommitdiffstats
path: root/src/socketengines/socketengine_ports.cpp
diff options
context:
space:
mode:
authorGravatar danieldg2010-03-02 03:17:04 +0000
committerGravatar Daniel De Graaf2010-08-03 17:32:38 -0400
commite3e66041453507a5d5d514fd99e4e14dc74bd614 (patch)
tree0e0f944bf1ec2b13e6113ddeeaae939ef7a539ee /src/socketengines/socketengine_ports.cpp
parentDon't try quite so hard to writev() the entire buffer in one go (diff)
downloadinspircd++-e3e66041453507a5d5d514fd99e4e14dc74bd614.tar.gz
inspircd++-e3e66041453507a5d5d514fd99e4e14dc74bd614.tar.bz2
inspircd++-e3e66041453507a5d5d514fd99e4e14dc74bd614.zip
DelFd should not fail, it will leave a bad dangling pointer in that case
Diffstat (limited to 'src/socketengines/socketengine_ports.cpp')
-rw-r--r--src/socketengines/socketengine_ports.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/socketengines/socketengine_ports.cpp b/src/socketengines/socketengine_ports.cpp
index 5642a7223..e5523acb6 100644
--- a/src/socketengines/socketengine_ports.cpp
+++ b/src/socketengines/socketengine_ports.cpp
@@ -48,7 +48,7 @@ public:
virtual ~PortsEngine();
virtual bool AddFd(EventHandler* eh, int event_mask);
void OnSetEvent(EventHandler* eh, int old_event, int new_event);
- virtual bool DelFd(EventHandler* eh, bool force = false);
+ virtual void DelFd(EventHandler* eh);
virtual int DispatchEvents();
virtual std::string GetName();
virtual void WantWrite(EventHandler* eh);
@@ -131,11 +131,11 @@ void PortsEngine::WantWrite(EventHandler* eh, int old_mask, int new_mask)
port_associate(EngineHandle, PORT_SOURCE_FD, eh->GetFd(), mask_to_events(new_mask), eh);
}
-bool PortsEngine::DelFd(EventHandler* eh, bool force)
+void PortsEngine::DelFd(EventHandler* eh)
{
int fd = eh->GetFd();
if ((fd < 0) || (fd > GetMaxFds() - 1))
- return false;
+ return;
port_dissociate(EngineHandle, PORT_SOURCE_FD, fd);