From b28782c4a3cd52587d61541bcca4e0b217685c54 Mon Sep 17 00:00:00 2001
From: Attila Molnar
Date: Sun, 17 May 2015 18:00:42 +0200
Subject: Fix incorrect iterator use leading to prematurely exiting loops when
 quitting users while looping the local user list

---
 src/modules/m_jumpserver.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'src/modules/m_jumpserver.cpp')

diff --git a/src/modules/m_jumpserver.cpp b/src/modules/m_jumpserver.cpp
index 599144448..e9c07f45f 100644
--- a/src/modules/m_jumpserver.cpp
+++ b/src/modules/m_jumpserver.cpp
@@ -109,9 +109,11 @@ class CommandJumpserver : public Command
 			{
 				/* Redirect everyone but the oper sending the command */
 				const UserManager::LocalList& list = ServerInstance->Users.GetLocalUsers();
-				for (UserManager::LocalList::const_iterator i = list.begin(); i != list.end(); ++i)
+				for (UserManager::LocalList::const_iterator i = list.begin(); i != list.end(); )
 				{
+					// Quitting the user removes it from the list
 					LocalUser* t = *i;
+					++i;
 					if (!t->IsOper())
 					{
 						t->WriteNumeric(RPL_REDIR, "%s %d :Please use this Server/Port instead", parameters[0].c_str(), GetPort(t));
-- 
cgit v1.3.1-10-gc9f91