From 2630a87bb13b089e6d0fdcff4bcd0f3a9612e52f Mon Sep 17 00:00:00 2001
From: danieldg
Date: Wed, 2 Sep 2009 00:43:04 +0000
Subject: Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7
---
 src/modules/m_nokicks.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

(limited to 'src/modules/m_nokicks.cpp')

diff --git a/src/modules/m_nokicks.cpp b/src/modules/m_nokicks.cpp
index 61ab868a5..ce43e576f 100644
--- a/src/modules/m_nokicks.cpp
+++ b/src/modules/m_nokicks.cpp
@@ -23,14 +23,13 @@ class NoKicks : public SimpleChannelModeHandler
 
 class ModuleNoKicks : public Module
 {
-	NoKicks* nk;
+	NoKicks nk;
 
  public:
 	ModuleNoKicks(InspIRCd* Me)
-		: Module(Me)
+		: Module(Me), nk(Me)
 	{
-		nk = new NoKicks(ServerInstance);
-		if (!ServerInstance->Modes->AddMode(nk))
+		if (!ServerInstance->Modes->AddMode(&nk))
 			throw ModuleException("Could not add new modes!");
 		Implementation eventlist[] = { I_OnAccessCheck, I_On005Numeric };
 		ServerInstance->Modules->Attach(eventlist, this, 2);
@@ -65,8 +64,7 @@ class ModuleNoKicks : public Module
 
 	virtual ~ModuleNoKicks()
 	{
-		ServerInstance->Modes->DelMode(nk);
-		delete nk;
+		ServerInstance->Modes->DelMode(&nk);
 	}
 
 	virtual Version GetVersion()
-- 
cgit v1.3.1-10-gc9f91