From 2630a87bb13b089e6d0fdcff4bcd0f3a9612e52f Mon Sep 17 00:00:00 2001
From: danieldg
Date: Wed, 2 Sep 2009 00:43:04 +0000
Subject: Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7
---
 src/modules/m_operchans.cpp | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

(limited to 'src/modules/m_operchans.cpp')

diff --git a/src/modules/m_operchans.cpp b/src/modules/m_operchans.cpp
index 50aa0aa87..8723f6ca0 100644
--- a/src/modules/m_operchans.cpp
+++ b/src/modules/m_operchans.cpp
@@ -47,14 +47,12 @@ class OperChans : public ModeHandler
 class ModuleOperChans : public Module
 {
 
-	OperChans* oc;
+	OperChans oc;
  public:
 	ModuleOperChans(InspIRCd* Me)
-		: Module(Me)
+		: Module(Me), oc(Me)
 	{
-
-		oc = new OperChans(ServerInstance);
-		if (!ServerInstance->Modes->AddMode(oc))
+		if (!ServerInstance->Modes->AddMode(&oc))
 			throw ModuleException("Could not add new modes!");
 		Implementation eventlist[] = { I_OnCheckBan, I_OnUserPreJoin };
 		ServerInstance->Modules->Attach(eventlist, this, 2);
@@ -81,8 +79,7 @@ class ModuleOperChans : public Module
 
 	virtual ~ModuleOperChans()
 	{
-		ServerInstance->Modes->DelMode(oc);
-		delete oc;
+		ServerInstance->Modes->DelMode(&oc);
 	}
 
 	virtual Version GetVersion()
-- 
cgit v1.3.1-10-gc9f91