From 758fc5fcbb988a1f3d692485e47cb8d253b2bc8d Mon Sep 17 00:00:00 2001
From: Peter Powell
Date: Tue, 28 Nov 2017 18:41:41 +0000
Subject: Use ERR_INVALIDUSERNAME rather than ERR_NEEDMOREPARAMS in USER.

This numeric is a lot more friendly for clients to deal with.
---
 src/coremods/core_user/cmd_user.cpp | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

(limited to 'src')

diff --git a/src/coremods/core_user/cmd_user.cpp b/src/coremods/core_user/cmd_user.cpp
index 8bf34665d..c4cdd9b37 100644
--- a/src/coremods/core_user/cmd_user.cpp
+++ b/src/coremods/core_user/cmd_user.cpp
@@ -21,6 +21,12 @@
 #include "inspircd.h"
 #include "core_user.h"
 
+enum
+{
+	// From ircu.
+	ERR_INVALIDUSERNAME = 468
+};
+
 CommandUser::CommandUser(Module* parent)
 	: SplitCommand(parent, "USER", 4, 4)
 {
@@ -36,11 +42,7 @@ CmdResult CommandUser::HandleLocal(const std::vector<std::string>& parameters, L
 	{
 		if (!ServerInstance->IsIdent(parameters[0]))
 		{
-			/*
-			 * RFC says we must use this numeric, so we do. Let's make it a little more nub friendly though. :)
-			 *  -- Craig, and then w00t.
-			 */
-			user->WriteNumeric(ERR_NEEDMOREPARAMS, name, "Your username is not valid");
+			user->WriteNumeric(ERR_INVALIDUSERNAME, name, "Your username is not valid");
 			return CMD_FAILURE;
 		}
 		else
-- 
cgit v1.3.1-10-gc9f91