aboutsummaryrefslogtreecommitdiffstats
path: root/src/modules/help
diff options
context:
space:
mode:
authorGravatar Fabio Bas2010-01-13 22:32:43 +0000
committerGravatar Fabio Bas2010-01-13 22:32:43 +0000
commitb01ceb835c17faa9e327b593ef143be111e93633 (patch)
treea0032fa0fc747147f5e276e56e09c28196dcc105 /src/modules/help
parentAdd names for mdichild objects (diff)
downloadKVIrc-b01ceb835c17faa9e327b593ef143be111e93633.tar.gz
KVIrc-b01ceb835c17faa9e327b593ef143be111e93633.tar.bz2
KVIrc-b01ceb835c17faa9e327b593ef143be111e93633.zip
avoid a race condition on help indexing
avoid crashes due to kvikvsactions deleted while their internal script is still executing (happens because we clear() out menu popups at every show, and a user could get a popup shown before its code finishes executing) git-svn-id: https://svn.kvirc.de/svn/trunk/kvirc@3836 17fca916-40b9-46aa-a4ea-0a15b648b75c
Diffstat (limited to 'src/modules/help')
-rw-r--r--src/modules/help/helpwindow.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/modules/help/helpwindow.cpp b/src/modules/help/helpwindow.cpp
index abc3b24f1..e4cb8f26b 100644
--- a/src/modules/help/helpwindow.cpp
+++ b/src/modules/help/helpwindow.cpp
@@ -51,6 +51,7 @@ KviHelpWindow::KviHelpWindow(KviFrame * lpFrm,const char * name)
{
if(!g_bIndexingDone)
{
+ g_bIndexingDone=TRUE;
QString szDoclist,szDict;
g_pApp->getLocalKvircDirectory(szDoclist,KviApp::Help,"help.doclist." KVI_SOURCES_DATE);
@@ -62,7 +63,6 @@ KviHelpWindow::KviHelpWindow(KviFrame * lpFrm,const char * name)
g_pDocIndex->makeIndex();
g_pDocIndex->writeDict();
}
- g_bIndexingDone=TRUE;
}
g_pHelpWindowList->append(this);