diff options
| author |  Alexey Sokolov | 2016-05-01 16:16:09 +0100 |
|---|---|---|
| committer | Alexey Sokolov | 2016-05-01 16:16:09 +0100 |
| commit | fe375f69972cd912739c0d68fa4951d35de90e5e (patch) | |
| tree | 71bd2c2b59d6be62d7c18588a417e5aa39ab233c /src/modules/objects/KvsObject_xmlreader.cpp | |
| parent | libkvidcc: fix $dcc.currentSpeed documentation add missing @short and fix rig... (diff) | |
| parent | Apply clang-tidy: modernize-loop-convert (diff) | |
| download | KVIrc-fe375f69972cd912739c0d68fa4951d35de90e5e.tar.gz KVIrc-fe375f69972cd912739c0d68fa4951d35de90e5e.tar.bz2 KVIrc-fe375f69972cd912739c0d68fa4951d35de90e5e.zip | |
Merge pull request #1962 from DarthGandalf/modernize
Apply several fixes of clang-tidy
Diffstat (limited to 'src/modules/objects/KvsObject_xmlreader.cpp')
| -rw-r--r-- | src/modules/objects/KvsObject_xmlreader.cpp | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/src/modules/objects/KvsObject_xmlreader.cpp b/src/modules/objects/KvsObject_xmlreader.cpp index 6cdd96b54..b7ebafe9f 100644 --- a/src/modules/objects/KvsObject_xmlreader.cpp +++ b/src/modules/objects/KvsObject_xmlreader.cpp @@ -130,9 +130,7 @@ public: { m_pReader = pReader; } - ~KviXmlHandler() - { - } + ~KviXmlHandler() override = default; private: bool kvsCodeFailure() @@ -162,7 +160,7 @@ private: } public: - virtual bool startDocument() + bool startDocument() override { KviKvsVariant ret; if(!m_pReader->callFunction(m_pReader, "onDocumentStart", &ret)) @@ -170,7 +168,7 @@ public: return handleKvsCallReturnValue(&ret); } - virtual bool endDocument() + bool endDocument() override { KviKvsVariant ret; if(!m_pReader->callFunction(m_pReader, "onDocumentEnd", &ret)) @@ -178,7 +176,7 @@ public: return handleKvsCallReturnValue(&ret); } - virtual bool startElement(const QString & szNamespaceUri, const QString & szLocalName, const QString & szQualifiedName, const QXmlAttributes & attrs) + bool startElement(const QString & szNamespaceUri, const QString & szLocalName, const QString & szQualifiedName, const QXmlAttributes & attrs) override { KviKvsVariant ret; KviKvsVariantList par; @@ -196,7 +194,7 @@ public: return handleKvsCallReturnValue(&ret); } - virtual bool endElement(const QString & szNamespaceUri, const QString & szLocalName, const QString & szQualifiedName) + bool endElement(const QString & szNamespaceUri, const QString & szLocalName, const QString & szQualifiedName) override { KviKvsVariant ret; KviKvsVariantList par; @@ -209,7 +207,7 @@ public: return handleKvsCallReturnValue(&ret); } - virtual bool characters(const QString & szChars) + bool characters(const QString & szChars) override { KviKvsVariant ret; KviKvsVariantList par; @@ -220,7 +218,7 @@ public: return handleKvsCallReturnValue(&ret); } - virtual bool warning(const QXmlParseException & exception) + bool warning(const QXmlParseException & exception) override { // recoverable QString szMsg; @@ -235,7 +233,7 @@ public: return handleKvsCallReturnValue(&ret); } - virtual bool error(const QXmlParseException & exception) + bool error(const QXmlParseException & exception) override { // recoverable QString szMsg; @@ -250,7 +248,7 @@ public: return handleKvsCallReturnValue(&ret); } - virtual bool fatalError(const QXmlParseException & exception) + bool fatalError(const QXmlParseException & exception) override { QString szMsg; decodeException(szMsg, true, exception); @@ -258,7 +256,7 @@ public: return true; } - virtual QString errorString() const + QString errorString() const override { return m_szErrorString; } |