diff options
| author |  IceN9ne | 2017-03-09 20:21:26 -0500 |
|---|---|---|
| committer | IceN9ne | 2017-03-09 20:21:26 -0500 |
| commit | 111cb9c64b7e7c14f0d95f3920ea88ba68327ae2 (patch) | |
| tree | f4adf52a543db97c907c3a08197d876237595f4d /src/modules | |
| parent | rijndael module: Fix potential memory leak and invalid length check (diff) | |
| download | KVIrc-111cb9c64b7e7c14f0d95f3920ea88ba68327ae2.tar.gz KVIrc-111cb9c64b7e7c14f0d95f3920ea88ba68327ae2.tar.bz2 KVIrc-111cb9c64b7e7c14f0d95f3920ea88ba68327ae2.zip | |
logview module: Fix memory leak in logview export
Diffstat (limited to 'src/modules')
| -rw-r--r-- | src/modules/logview/LogViewWindow.h | 2 | ||||
| -rw-r--r-- | src/modules/logview/libkvilogview.cpp | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/modules/logview/LogViewWindow.h b/src/modules/logview/LogViewWindow.h index 971166b95..c2e2ed850 100644 --- a/src/modules/logview/LogViewWindow.h +++ b/src/modules/logview/LogViewWindow.h @@ -113,7 +113,7 @@ public: * \param pszFile The buffer to store the exported log name * \return void */ - void createLog(LogFile * pLog, int iId, QString * pszFile = 0); + void createLog(LogFile * pLog, int iId, QString * pszFile = nullptr); protected: void exportLog(int iId); diff --git a/src/modules/logview/libkvilogview.cpp b/src/modules/logview/libkvilogview.cpp index 3304ddc8b..d4255726e 100644 --- a/src/modules/logview/libkvilogview.cpp +++ b/src/modules/logview/libkvilogview.cpp @@ -107,12 +107,12 @@ static bool logview_module_ctrl(KviModule *, const char * pcOperation, void * pP if(!pData) return false; - LogFile * pLog = new LogFile(pData->szName); + LogFile log{pData->szName}; int iId = LogFile::PlainText; - if(pData->szType == "html") + if(pData->szType == QLatin1String("html")) iId = LogFile::HTML; - g_pLogViewWindow->createLog(pLog, iId, &(pData->szFile)); + g_pLogViewWindow->createLog(&log, iId, &(pData->szFile)); return true; } |