Fix Coverity complaints about uninitialized member variables

13 files changed, 22 insertions, 35 deletions

diff --git a/src/modules/actioneditor/ActionEditor.h b/src/modules/actioneditor/ActionEditor.h
index 0877f524a..8a88c7778 100644
--- a/src/modules/actioneditor/ActionEditor.h
+++ b/src/modules/actioneditor/ActionEditor.h
@@ -79,9 +79,6 @@ public:
 
 protected:
 	ActionData * m_pActionData;
-	//QSimpleRichText * m_pText;
-	QTextDocument * m_pText;
-	QPixmap * m_pIcon;
 	QTreeWidget * m_pTreeWidget;
 	QString m_szKey;
 
diff --git a/src/modules/addon/AddonManagementDialog.h b/src/modules/addon/AddonManagementDialog.h
index 2a1a50d74..b2181c502 100644
--- a/src/modules/addon/AddonManagementDialog.h
+++ b/src/modules/addon/AddonManagementDialog.h
@@ -47,8 +47,6 @@ public:
 
 protected:
 	KviKvsScriptAddon * m_pAddon;
-	QTextDocument * m_pText;
-	QPixmap * m_pIcon;
 	QListWidget * m_pListWidget;
 	QString m_szKey;
 
diff --git a/src/modules/addon/PackAddonDialog.h b/src/modules/addon/PackAddonDialog.h
index e9b88bc33..d6ddec1f1 100644
--- a/src/modules/addon/PackAddonDialog.h
+++ b/src/modules/addon/PackAddonDialog.h
@@ -226,10 +226,6 @@ public:
 
 protected:
 	QLabel * m_pLabelInfo;
-	QLabel * m_pLabelAuthor;
-	QLabel * m_pPackageName;
-	QLabel * m_pPackageVersion;
-	QLabel * m_pPackageDescription;
 
 protected:
 	/**
diff --git a/src/modules/dcc/DccFileTransfer.h b/src/modules/dcc/DccFileTransfer.h
index f8fb48a05..c9a8b5ddb 100644
--- a/src/modules/dcc/DccFileTransfer.h
+++ b/src/modules/dcc/DccFileTransfer.h
@@ -74,8 +74,8 @@ private:
 	uint m_uAverageSpeed;
 	uint m_uInstantSpeed;
 	quint64 m_uFilePosition;
-	quint64 m_uAckedBytes;
-	quint64 m_uTotalSentBytes;
+	quint64 m_uAckedBytes = 0;
+	quint64 m_uTotalSentBytes = 0;
 	// internal
 	unsigned long m_uStartTime;
 	unsigned long m_uInstantSpeedInterval;
diff --git a/src/modules/eventeditor/EventEditorWindow.h b/src/modules/eventeditor/EventEditorWindow.h
index 211733c22..670b1e427 100644
--- a/src/modules/eventeditor/EventEditorWindow.h
+++ b/src/modules/eventeditor/EventEditorWindow.h
@@ -101,7 +101,7 @@ public:
 	EventEditorTreeWidget * m_pTreeWidget;
 	QLineEdit * m_pNameEditor;
 	QCheckBox * m_pIsEnabled;
-	QMenu * m_pContextPopup;
+	QMenu * m_pContextPopup = nullptr;
 	EventEditorHandlerTreeWidgetItem * m_pLastEditedItem;
 	bool m_bOneTimeSetupDone;
 
diff --git a/src/modules/logview/LogViewWindow.h b/src/modules/logview/LogViewWindow.h
index c2e2ed850..dfe267426 100644
--- a/src/modules/logview/LogViewWindow.h
+++ b/src/modules/logview/LogViewWindow.h
@@ -89,7 +89,6 @@ protected:
 	QDateEdit * m_pFromDateEdit;
 	QDateEdit * m_pToDateEdit;
 
-	QStringList * m_pFileNames;
 	QTabWidget * m_pTabWidget;
 	KviTalVBox * m_pIndexTab;
 	KviTalVBox * m_pLeftLayout;
@@ -98,10 +97,10 @@ protected:
 	QPushButton * m_pCancelButton;
 	KviTalHBox * m_pBottomLayout;
 	QProgressBar * m_pProgressBar;
-	LogListViewItem * m_pLastCategory;
-	LogListViewItemFolder * m_pLastGroupItem;
+	LogListViewItem * m_pLastCategory = nullptr;
+	LogListViewItemFolder * m_pLastGroupItem = nullptr;
 	QString m_szLastGroup;
-	bool m_bAborted;
+	bool m_bAborted = false;
 	QTimer * m_pTimer;
 	QMenu * m_pExportLogPopup;
 
diff --git a/src/modules/objects/KvsObject_socket.h b/src/modules/objects/KvsObject_socket.h
index 2bb623be9..94ec58f5c 100644
--- a/src/modules/objects/KvsObject_socket.h
+++ b/src/modules/objects/KvsObject_socket.h
@@ -35,10 +35,10 @@ class KvsObject_socket : public KviKvsObject
 public:
 	KVSO_DECLARE_OBJECT(KvsObject_socket)
 protected:
-	QAbstractSocket * m_pSocket;
-	QTcpServer * m_pServer;
-	KviKvsRunTimeContext * m_pContext;
-	bool bIsSetFromExternal;
+	QAbstractSocket * m_pSocket = nullptr;
+	QTcpServer * m_pServer = nullptr;
+	KviKvsRunTimeContext * m_pContext = nullptr;
+	bool bIsSetFromExternal = false;
 
 protected:
 	virtual bool init(KviKvsRunTimeContext * pContext, KviKvsVariantList * pParams);
diff --git a/src/modules/objects/KvsObject_tableWidget.h b/src/modules/objects/KvsObject_tableWidget.h
index b25613c36..5f58804b7 100644
--- a/src/modules/objects/KvsObject_tableWidget.h
+++ b/src/modules/objects/KvsObject_tableWidget.h
@@ -60,8 +60,8 @@ public:
 	bool paint(QPainter * pPainter, const QStyleOptionViewItem & option, const QModelIndex & index);
 
 protected:
-	KviKvsRunTimeContext * m_pContext;
-	KviCellItemDelegate * m_pCellItemDelegate;
+	KviKvsRunTimeContext * m_pContext = nullptr;
+	KviCellItemDelegate * m_pCellItemDelegate = nullptr;
 
 protected:
 	virtual bool init(KviKvsRunTimeContext * pContext, KviKvsVariantList * pParams);
diff --git a/src/modules/objects/KvsObject_webView.h b/src/modules/objects/KvsObject_webView.h
index 45de20ceb..de0457d76 100644
--- a/src/modules/objects/KvsObject_webView.h
+++ b/src/modules/objects/KvsObject_webView.h
@@ -65,16 +65,16 @@ class KvsObject_webView : public KviKvsObject
 public:
 	KVSO_DECLARE_OBJECT(KvsObject_webView)
 protected:
-	KviKvsRunTimeContext * m_pContext;
-	int elementMapId;
+	KviKvsRunTimeContext * m_pContext = nullptr;
+	int elementMapId = 1;
 	int insertElement(const QWebElement & ele);
 	QWebElement getElement(int iIdx);
 	int getElementId(const QWebElement &);
 	QHash<int, QWebElement> m_elementMapper;
-	KviPointerList<KviKvsObject> * lWebelement;
+	KviPointerList<KviKvsObject> * lWebelement = nullptr;
 	QHash<QString, QWebElement *> m_dictCache;
-	KviPointerList<QNetworkReply> * m_pReplyList;
-	QNetworkAccessManager * m_pNetworkManager;
+	KviPointerList<QNetworkReply> * m_pReplyList = nullptr;
+	QNetworkAccessManager * m_pNetworkManager = nullptr;
 	QWebElementCollection m_webElementCollection;
 	QWebElement m_currentElement;
 
diff --git a/src/modules/objects/KvsObject_widget.h b/src/modules/objects/KvsObject_widget.h
index 4d35b34e1..2c8e24b67 100644
--- a/src/modules/objects/KvsObject_widget.h
+++ b/src/modules/objects/KvsObject_widget.h
@@ -49,11 +49,11 @@ protected:
 	virtual bool init(KviKvsRunTimeContext * pContext, KviKvsVariantList * pParams);
 
 #ifdef COMPILE_WEBKIT_SUPPORT
-	QWebView * m_pWebview;
+	QWebView * m_pWebview = nullptr;
 #endif
 	virtual bool eventFilter(QObject * o, QEvent * e);
-	KviKvsRunTimeContext * m_pContext;
-	QGraphicsDropShadowEffect * pGraphicsEffect;
+	KviKvsRunTimeContext * m_pContext = nullptr;
+	QGraphicsDropShadowEffect * pGraphicsEffect = nullptr;
 	// ok, it is clear that we're messing with the naming conventions for the
 	// object classes :D
 	// let's try to use this one:
diff --git a/src/modules/options/OptionsWidget_servers.h b/src/modules/options/OptionsWidget_servers.h
index b6a2fdb68..5d69bb00f 100644
--- a/src/modules/options/OptionsWidget_servers.h
+++ b/src/modules/options/OptionsWidget_servers.h
@@ -193,18 +193,15 @@ protected:
 	QMenu * m_pImportPopup;
 	KviIrcServer * m_pClipboard;
 	QPushButton * m_pConnectCurrent;
-	QPushButton * m_pConnectNew;
 	IrcServerOptionsTreeWidgetItem * m_pLastEditedItem;
 	IrcServerDetailsWidget * m_pServerDetailsDialog;
 	IrcNetworkDetailsWidget * m_pNetworkDetailsDialog;
 	KviMexServerImport * m_pImportFilter;
 	KviBoolSelector * m_pShowThisDialogAtStartupSelector;
-	KviBoolSelector * m_pShowFavoritesOnly;
 
 	QToolButton * m_pNewServerButton;
 	QToolButton * m_pNewNetworkButton;
 	QToolButton * m_pRemoveButton;
-	QToolButton * m_pFavoriteServer;
 	QToolButton * m_pCopyServerButton;
 	QToolButton * m_pPasteServerButton;
 	QToolButton * m_pImportButton;
diff --git a/src/modules/options/OptionsWidget_textIcons.h b/src/modules/options/OptionsWidget_textIcons.h
index e1b78f2ba..bcfcfc80b 100644
--- a/src/modules/options/OptionsWidget_textIcons.h
+++ b/src/modules/options/OptionsWidget_textIcons.h
@@ -67,7 +67,7 @@ public:
 protected:
 	QTableWidget * m_pTable;
 	int m_iLastEditedRow;
-	TextIconTableItem * m_pCurrentItem;
+	TextIconTableItem * m_pCurrentItem = nullptr;
 	QPushButton * m_pAdd;
 	QPushButton * m_pDel;
 	QPushButton * m_pRestore;
diff --git a/src/modules/url/libkviurl.h b/src/modules/url/libkviurl.h
index 623d11b5a..a26ad3836 100644
--- a/src/modules/url/libkviurl.h
+++ b/src/modules/url/libkviurl.h
@@ -80,7 +80,7 @@ public:
 
 private:
 	KviTalMenuBar * m_pMenuBar;
-	QMenu * m_pListPopup; // dynamic popup menu
+	QMenu * m_pListPopup = nullptr; // dynamic popup menu
 	QString m_szUrl;      // used to pass URLs to sayToWin slot
 protected:
 	QPixmap * myIconPtr();