aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Runxi Yu2026-03-29 07:04:01 +0000
committerGravatar Runxi Yu2026-03-29 07:04:01 +0000
commit0eb5adaa6fda00b328c8a6242adb20a5bfeb6959 (patch)
tree99021e8384e052ebc19e8df7d4a8cb0c7b40be48
parent*: Repeated calls to Close are UB by default (diff)
signatureNo signature
*: Remove Close exception for MT-Safe v0.1.133
-rw-r--r--format/commitgraph/read/close.go2
-rw-r--r--furgit.go3
-rw-r--r--object/store/chain/close.go2
-rw-r--r--object/store/loose/store.go2
-rw-r--r--object/store/memory/store.go2
-rw-r--r--object/store/mix/close.go2
-rw-r--r--object/store/packed/close.go2
-rw-r--r--object/store/reading.go2
-rw-r--r--ref/store/chain/close.go2
-rw-r--r--ref/store/files/close.go2
-rw-r--r--ref/store/reading.go2
11 files changed, 21 insertions, 2 deletions
diff --git a/format/commitgraph/read/close.go b/format/commitgraph/read/close.go
index d91c7762..c13b5f55 100644
--- a/format/commitgraph/read/close.go
+++ b/format/commitgraph/read/close.go
@@ -1,6 +1,8 @@
package read
// Close releases all mapped commit-graph files.
+//
+// Labels: MT-Unsafe.
func (reader *Reader) Close() error {
var closeErr error
diff --git a/furgit.go b/furgit.go
index a43f6d40..4f57e70d 100644
--- a/furgit.go
+++ b/furgit.go
@@ -12,8 +12,7 @@
//
// Concurrency labels:
//
-// - MT-Safe: safe for concurrent use, excluding Close unless documented
-// otherwise.
+// - MT-Safe: safe for concurrent use.
// - MT-ReadSafe: safe for concurrent read-only use.
// - MT-Unsafe: not safe for concurrent use without external synchronization.
//
diff --git a/object/store/chain/close.go b/object/store/chain/close.go
index 403e178e..75fa357e 100644
--- a/object/store/chain/close.go
+++ b/object/store/chain/close.go
@@ -1,4 +1,6 @@
package chain
// Close releases wrapper-local resources.
+//
+// Labels: MT-Unsafe.
func (chain *Chain) Close() error { return nil }
diff --git a/object/store/loose/store.go b/object/store/loose/store.go
index ac9a4d99..ea466284 100644
--- a/object/store/loose/store.go
+++ b/object/store/loose/store.go
@@ -38,4 +38,6 @@ func New(root *os.Root, algo objectid.Algorithm) (*Store, error) {
}
// Close releases resources associated with the backend.
+//
+// Labels: MT-Unsafe.
func (store *Store) Close() error { return nil }
diff --git a/object/store/memory/store.go b/object/store/memory/store.go
index bc6795ab..ff66da50 100644
--- a/object/store/memory/store.go
+++ b/object/store/memory/store.go
@@ -21,6 +21,8 @@ func New(algo objectid.Algorithm) *Store {
}
// Close closes the in-memory store.
+//
+// Labels: MT-Unsafe.
func (store *Store) Close() error {
return nil
}
diff --git a/object/store/mix/close.go b/object/store/mix/close.go
index a614e586..51f7aa18 100644
--- a/object/store/mix/close.go
+++ b/object/store/mix/close.go
@@ -1,4 +1,6 @@
package mix
// Close releases wrapper-local resources.
+//
+// Labels: MT-Unsafe.
func (mix *Mix) Close() error { return nil }
diff --git a/object/store/packed/close.go b/object/store/packed/close.go
index 6c61e4e6..6ad31aac 100644
--- a/object/store/packed/close.go
+++ b/object/store/packed/close.go
@@ -1,6 +1,8 @@
package packed
// Close releases mapped pack/index resources associated with the store.
+//
+// Labels: MT-Unsafe.
func (store *Store) Close() error {
store.stateMu.Lock()
packs := store.packs
diff --git a/object/store/reading.go b/object/store/reading.go
index 9a487bcf..d27001bf 100644
--- a/object/store/reading.go
+++ b/object/store/reading.go
@@ -54,5 +54,7 @@ type ReadingStore interface {
Refresh() error
// Close releases resources associated with the backend.
+ //
+ // Labels: MT-Unsafe.
Close() error
}
diff --git a/ref/store/chain/close.go b/ref/store/chain/close.go
index 403e178e..75fa357e 100644
--- a/ref/store/chain/close.go
+++ b/ref/store/chain/close.go
@@ -1,4 +1,6 @@
package chain
// Close releases wrapper-local resources.
+//
+// Labels: MT-Unsafe.
func (chain *Chain) Close() error { return nil }
diff --git a/ref/store/files/close.go b/ref/store/files/close.go
index 0e5212d0..84a69dab 100644
--- a/ref/store/files/close.go
+++ b/ref/store/files/close.go
@@ -1,6 +1,8 @@
package files
// Close releases resources associated with the store.
+//
+// Labels: MT-Unsafe.
func (store *Store) Close() error {
return store.commonRoot.Close()
}
diff --git a/ref/store/reading.go b/ref/store/reading.go
index 66528127..99f8278c 100644
--- a/ref/store/reading.go
+++ b/ref/store/reading.go
@@ -34,5 +34,7 @@ type ReadingStore interface {
// Close releases resources associated with the store.
//
// Transactions and batches borrowing the store are invalid after Close.
+ //
+ // Labels: MT-Unsafe.
Close() error
}