diff options
| author | 2025-11-16 00:00:00 +0000 | |
|---|---|---|
| committer | 2025-11-16 00:00:00 +0000 | |
| commit | 71f01941987aa11f638e21c8aeea35e1aa7c7a73 (patch) | |
| tree | e92d446462ff4e82c6266d1ec978f97fb32db423 | |
| parent | All Serialize should be able to error out (diff) | |
| signature | ||
Fix tests using the wrong Serialize signatures
| -rw-r--r-- | ident_test.go | 12 | ||||
| -rw-r--r-- | objects_test.go | 14 |
2 files changed, 21 insertions, 5 deletions
diff --git a/ident_test.go b/ident_test.go index 032dee4c..76e1fb04 100644 --- a/ident_test.go +++ b/ident_test.go @@ -14,7 +14,11 @@ func TestParseIdentRoundTrip(t *testing.T) { if got := string(id.Email); got != "alice@example.com" { t.Fatalf("email mismatch: %q", got) } - serialized := string(id.Serialize()) + ids, err := id.Serialize() + if err != nil { + t.Fatalf("Serialize error: %v", err) + } + serialized := string(ids) if !strings.Contains(serialized, "alice@example.com") { t.Fatalf("Serialize missing email: %q", serialized) } @@ -47,7 +51,11 @@ func TestIdentSerializeUsesCanonicalSpacing(t *testing.T) { WhenUnix: 1000, OffsetMinutes: 90, } - got := string(id.Serialize()) + ids, err := id.Serialize() + if err != nil { + t.Fatalf("Serialize error: %v", err) + } + got := string(ids) if !strings.Contains(got, "Bob <bob@example.com>") { t.Fatalf("unexpected serialize output: %q", got) } diff --git a/objects_test.go b/objects_test.go index 3fb48c53..e9e21ac0 100644 --- a/objects_test.go +++ b/objects_test.go @@ -119,10 +119,14 @@ func TestParseCommitWithExtraHeader(t *testing.T) { fmt.Fprintf(&buf, "tree %s\n", treeID.String()) fmt.Fprintf(&buf, "parent %s\n", parent.String()) buf.WriteString("author ") - buf.Write(ident.Serialize()) + ids, err := ident.Serialize() + if err != nil { + t.Fatalf("Serialize error: %v", err) + } + buf.Write(ids) buf.WriteByte('\n') buf.WriteString("committer ") - buf.Write(ident.Serialize()) + buf.Write(ids) buf.WriteByte('\n') buf.WriteString("extra data\n\nMessage body\n") repo := testRepo(t) @@ -174,7 +178,11 @@ func TestParseTagAndSerialize(t *testing.T) { buf.WriteString("type commit\n") buf.WriteString("tag v1.0\n") buf.WriteString("tagger ") - buf.Write(tagger.Serialize()) + tgs, err := tagger.Serialize() + if err != nil { + t.Fatalf("Serialize error: %v", err) + } + buf.Write(tgs) buf.WriteString("\n\nannotated tag\n") body := append([]byte(nil), buf.Bytes()...) repo := testRepo(t) |
