aboutsummaryrefslogtreecommitdiff
path: root/internal/compress
diff options
context:
space:
mode:
authorGravatar Runxi Yu2026-03-05 21:09:07 +0800
committerGravatar Runxi Yu2026-03-05 21:14:24 +0800
commit355f5b3dc9ae560827cd274e113f43d09ee9ac49 (patch)
tree2046f5d51110fff82aecf35c75884222f51ac36c /internal/compress
parentobjectid, format/pack/ingest: Pack hash ID in algo (diff)
signatureNo signature
*: Fix overflows
Diffstat (limited to 'internal/compress')
-rw-r--r--internal/compress/zlib/reader.go17
-rw-r--r--internal/compress/zlib/reader_reset.go19
2 files changed, 32 insertions, 4 deletions
diff --git a/internal/compress/zlib/reader.go b/internal/compress/zlib/reader.go
index a6497dec..f298a07f 100644
--- a/internal/compress/zlib/reader.go
+++ b/internal/compress/zlib/reader.go
@@ -41,6 +41,7 @@ import (
"sync"
"codeberg.org/lindenii/furgit/internal/compress/flate"
+ "codeberg.org/lindenii/furgit/internal/intconv"
)
const (
@@ -131,7 +132,14 @@ func (z *Reader) Read(p []byte) (int, error) {
// Finished file; check checksum.
readN, err := io.ReadFull(z.r, z.scratch[0:4])
- z.trailerRead += uint64(readN)
+ readNUint64, convErr := intconv.IntToUint64(readN)
+ if convErr != nil {
+ z.err = convErr
+
+ return n, z.err
+ }
+
+ z.trailerRead += readNUint64
if err != nil {
if errors.Is(err, io.EOF) {
@@ -160,7 +168,12 @@ func (z *Reader) Read(p []byte) (int, error) {
func (z *Reader) InputConsumed() uint64 {
out := z.headerRead + z.trailerRead
if z.progress != nil {
- out += uint64(z.progress.InputConsumed())
+ progressIn, err := intconv.Int64ToUint64(z.progress.InputConsumed())
+ if err != nil {
+ panic(err)
+ }
+
+ out += progressIn
}
return out
diff --git a/internal/compress/zlib/reader_reset.go b/internal/compress/zlib/reader_reset.go
index 32af0b49..3e78ab5d 100644
--- a/internal/compress/zlib/reader_reset.go
+++ b/internal/compress/zlib/reader_reset.go
@@ -12,6 +12,7 @@ import (
"codeberg.org/lindenii/furgit/internal/adler32"
"codeberg.org/lindenii/furgit/internal/compress/flate"
+ "codeberg.org/lindenii/furgit/internal/intconv"
)
// reset resets receiver to read a new zlib stream.
@@ -29,7 +30,14 @@ func (z *Reader) reset(r io.Reader, dict []byte) error {
// Read the header (RFC 1950 section 2.2.).
readN, err := io.ReadFull(z.r, z.scratch[0:2])
- z.headerRead += uint64(readN)
+ readNUint64, convErr := intconv.IntToUint64(readN)
+ if convErr != nil {
+ z.err = convErr
+
+ return z.err
+ }
+
+ z.headerRead += readNUint64
z.err = err
if z.err != nil {
@@ -51,7 +59,14 @@ func (z *Reader) reset(r io.Reader, dict []byte) error {
if haveDict {
readN, z.err = io.ReadFull(z.r, z.scratch[0:4])
- z.headerRead += uint64(readN)
+ readNUint64, err := intconv.IntToUint64(readN)
+ if err != nil {
+ z.err = err
+
+ return z.err
+ }
+
+ z.headerRead += readNUint64
if z.err != nil {
if errors.Is(z.err, io.EOF) {
z.err = io.ErrUnexpectedEOF