receivepack: Set permissions properly

3 files changed, 111 insertions, 9 deletions

diff --git a/receivepack/internal/service/options.go b/receivepack/internal/service/options.go
index 4ba06827..c3d6c961 100644
--- a/receivepack/internal/service/options.go
+++ b/receivepack/internal/service/options.go
@@ -1,6 +1,7 @@
 package service
 
 import (
+	"io/fs"
 	"os"
 
 	"codeberg.org/lindenii/furgit/objectid"
@@ -8,11 +9,17 @@ import (
 	"codeberg.org/lindenii/furgit/refstore"
 )
 
+type PromotedObjectPermissions struct {
+	DirMode  fs.FileMode
+	FileMode fs.FileMode
+}
+
 // Options configures one protocol-independent receive-pack service.
 type Options struct {
-	Algorithm       objectid.Algorithm
-	Refs            refstore.ReadWriteStore
-	ExistingObjects objectstore.Store
-	ObjectsRoot     *os.Root
+	Algorithm                  objectid.Algorithm
+	Refs                       refstore.ReadWriteStore
+	ExistingObjects            objectstore.Store
+	ObjectsRoot                *os.Root
+	PromotedObjectPermissions  *PromotedObjectPermissions
 	// TODO: Hook and such callbacks.
 }
diff --git a/receivepack/internal/service/quarantine.go b/receivepack/internal/service/quarantine.go
index e028f54d..f263186b 100644
--- a/receivepack/internal/service/quarantine.go
+++ b/receivepack/internal/service/quarantine.go
@@ -71,6 +71,11 @@ func (service *Service) promoteQuarantineDir(quarantineName string, quarantineRo
 				return err
 			}
 
+			err = service.applyPromotedDirectoryPermissions(childRel)
+			if err != nil {
+				return err
+			}
+
 			err = service.promoteQuarantineDir(quarantineName, quarantineRoot, childRel)
 			if err != nil {
 				return err
@@ -84,6 +89,7 @@ func (service *Service) promoteQuarantineDir(quarantineName string, quarantineRo
 			path.Join(quarantineName, childRel),
 			childRel,
 			isLooseObjectShardPath(rel),
+			service.opts.PromotedObjectPermissions,
 		)
 		if err == nil {
 			continue
@@ -126,7 +132,32 @@ func isHex(ch byte) bool {
 	return ('0' <= ch && ch <= '9') || ('a' <= ch && ch <= 'f') || ('A' <= ch && ch <= 'F')
 }
 
-func finalizeQuarantineFile(root *os.Root, src, dst string, skipCollisionCheck bool) error {
+func (service *Service) applyPromotedDirectoryPermissions(name string) error {
+	if service.opts.PromotedObjectPermissions == nil {
+		return nil
+	}
+
+	return service.opts.ObjectsRoot.Chmod(name, service.opts.PromotedObjectPermissions.DirMode)
+}
+
+func applyPromotedFilePermissions(
+	root *os.Root,
+	name string,
+	perms *PromotedObjectPermissions,
+) error {
+	if perms == nil {
+		return nil
+	}
+
+	return root.Chmod(name, perms.FileMode)
+}
+
+func finalizeQuarantineFile(
+	root *os.Root,
+	src, dst string,
+	skipCollisionCheck bool,
+	perms *PromotedObjectPermissions,
+) error {
 	const maxVanishedRetries = 5
 
 	for retries := 0; ; retries++ {
@@ -135,7 +166,7 @@ func finalizeQuarantineFile(root *os.Root, src, dst string, skipCollisionCheck b
 		case err == nil:
 			_ = root.Remove(src)
 
-			return nil
+			return applyPromotedFilePermissions(root, dst, perms)
 		case !errors.Is(err, fs.ErrExist):
 			_, statErr := root.Stat(dst)
 			if statErr == nil {
@@ -143,7 +174,7 @@ func finalizeQuarantineFile(root *os.Root, src, dst string, skipCollisionCheck b
 			} else if errors.Is(statErr, fs.ErrNotExist) {
 				renameErr := root.Rename(src, dst)
 				if renameErr == nil {
-					return nil
+					return applyPromotedFilePermissions(root, dst, perms)
 				}
 
 				err = renameErr
@@ -163,7 +194,7 @@ func finalizeQuarantineFile(root *os.Root, src, dst string, skipCollisionCheck b
 		if skipCollisionCheck {
 			_ = root.Remove(src)
 
-			return nil
+			return applyPromotedFilePermissions(root, dst, perms)
 		}
 
 		equal, vanished, cmpErr := compareRootFiles(root, src, dst)
@@ -185,7 +216,7 @@ func finalizeQuarantineFile(root *os.Root, src, dst string, skipCollisionCheck b
 
 		_ = root.Remove(src)
 
-		return nil
+		return applyPromotedFilePermissions(root, dst, perms)
 	}
 }
 
diff --git a/receivepack/internal/service/quarantine_test.go b/receivepack/internal/service/quarantine_test.go
index 795fb35d..b28868ed 100644
--- a/receivepack/internal/service/quarantine_test.go
+++ b/receivepack/internal/service/quarantine_test.go
@@ -9,6 +9,70 @@ import (
 	"codeberg.org/lindenii/furgit/objectstore/memory"
 )
 
+func TestPromoteQuarantineAppliesConfiguredPermissions(t *testing.T) {
+	t.Parallel()
+
+	objectsDir := t.TempDir()
+	objectsRoot, err := os.OpenRoot(objectsDir)
+	if err != nil {
+		t.Fatalf("os.OpenRoot: %v", err)
+	}
+
+	t.Cleanup(func() {
+		_ = objectsRoot.Close()
+	})
+
+	svc := New(Options{
+		Algorithm:       objectid.AlgorithmSHA1,
+		ExistingObjects: memory.New(objectid.AlgorithmSHA1),
+		ObjectsRoot:     objectsRoot,
+		PromotedObjectPermissions: &PromotedObjectPermissions{
+			DirMode:  0o751,
+			FileMode: 0o640,
+		},
+	})
+
+	quarantineName, quarantineRoot, err := svc.createQuarantineRoot()
+	if err != nil {
+		t.Fatalf("createQuarantineRoot: %v", err)
+	}
+
+	t.Cleanup(func() {
+		_ = quarantineRoot.Close()
+		_ = objectsRoot.RemoveAll(quarantineName)
+	})
+
+	if err := quarantineRoot.Mkdir("ab", 0o700); err != nil {
+		t.Fatalf("Mkdir(ab): %v", err)
+	}
+
+	if err := quarantineRoot.WriteFile(path.Join("ab", "cdef"), []byte("payload"), 0o600); err != nil {
+		t.Fatalf("WriteFile(quarantine loose): %v", err)
+	}
+
+	if err := svc.promoteQuarantine(quarantineName, quarantineRoot); err != nil {
+		t.Fatalf("promoteQuarantine: %v", err)
+	}
+
+	dirInfo, err := objectsRoot.Stat("ab")
+	if err != nil {
+		t.Fatalf("Stat(ab): %v", err)
+	}
+
+	if got := dirInfo.Mode().Perm(); got != 0o751 {
+		t.Fatalf("dir mode = %o, want 751", got)
+	}
+
+	fileInfo, err := objectsRoot.Stat(path.Join("ab", "cdef"))
+	if err != nil {
+		t.Fatalf("Stat(ab/cdef): %v", err)
+	}
+
+	if got := fileInfo.Mode().Perm(); got != 0o640 {
+		t.Fatalf("file mode = %o, want 640", got)
+	}
+}
+
 func TestPromoteQuarantineTreatsExistingLooseObjectAsSuccess(t *testing.T) {
 	t.Parallel()