1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
|
package memory
import (
"errors"
"fmt"
"strings"
objectid "codeberg.org/lindenii/furgit/object/id"
refname "codeberg.org/lindenii/furgit/ref/name"
refstore "codeberg.org/lindenii/furgit/ref/store"
)
type updateKind uint8
const (
updateCreate updateKind = iota
updateReplace
updateDelete
updateVerify
updateCreateSymbolic
updateReplaceSymbolic
updateDeleteSymbolic
updateVerifySymbolic
)
type queuedUpdate struct {
name string
kind updateKind
newID objectid.ObjectID
oldID objectid.ObjectID
newTarget string
oldTarget string
}
type resolvedUpdateTarget struct {
name string
ref storedRef
}
type preparedUpdate struct {
op queuedUpdate
target resolvedUpdateTarget
}
type updateContextError struct {
name string
err error
}
func (err *updateContextError) Error() string {
return fmt.Sprintf("refstore/memory: update %q: %v", err.name, err.err)
}
func (err *updateContextError) Unwrap() error {
if err == nil {
return nil
}
return err.err
}
func wrapUpdateError(name string, err error) error {
if err == nil || name == "" {
return err
}
return &updateContextError{name: name, err: err}
}
func validateQueuedUpdate(op queuedUpdate) error {
if op.name == "" {
return wrapUpdateError(op.name, &refstore.InvalidNameError{Err: fmt.Errorf("empty reference name")})
}
switch op.kind {
case updateCreate, updateReplace:
err := refname.ValidateUpdateName(op.name, true)
if err != nil {
return wrapUpdateError(op.name, &refstore.InvalidNameError{Err: err})
}
if op.newID.Algorithm().Size() == 0 {
return wrapUpdateError(op.name, &refstore.InvalidValueError{Err: objectid.ErrInvalidAlgorithm})
}
case updateDelete, updateVerify:
err := refname.ValidateUpdateName(op.name, false)
if err != nil {
return wrapUpdateError(op.name, &refstore.InvalidNameError{Err: err})
}
if op.oldID.Algorithm().Size() == 0 {
return wrapUpdateError(op.name, &refstore.InvalidValueError{Err: objectid.ErrInvalidAlgorithm})
}
case updateCreateSymbolic, updateReplaceSymbolic:
err := refname.ValidateUpdateName(op.name, true)
if err != nil {
return wrapUpdateError(op.name, &refstore.InvalidNameError{Err: err})
}
if strings.TrimSpace(op.newTarget) == "" {
return wrapUpdateError(op.name, &refstore.InvalidValueError{Err: fmt.Errorf("empty symbolic target")})
}
err = refname.ValidateSymbolicTarget(op.name, strings.TrimSpace(op.newTarget))
if err != nil {
return wrapUpdateError(op.name, &refstore.InvalidValueError{Err: err})
}
case updateDeleteSymbolic, updateVerifySymbolic:
err := refname.ValidateUpdateName(op.name, false)
if err != nil {
return wrapUpdateError(op.name, &refstore.InvalidNameError{Err: err})
}
default:
return fmt.Errorf("refstore/memory: unsupported update operation %d", op.kind)
}
if op.kind == updateReplaceSymbolic || op.kind == updateDeleteSymbolic || op.kind == updateVerifySymbolic {
if strings.TrimSpace(op.oldTarget) == "" {
return wrapUpdateError(op.name, &refstore.InvalidValueError{Err: fmt.Errorf("empty symbolic old target")})
}
}
return nil
}
func prepareUpdates(refs map[string]storedRef, ops []queuedUpdate) ([]preparedUpdate, error) {
prepared, err := resolvePreparedUpdates(refs, ops)
if err != nil {
return prepared, err
}
deleted, written := collectPreparedWrites(prepared)
existing := collectVisibleNames(refs)
for _, name := range written {
err = verifyRefnameAvailable(name, existing, written, deleted)
if err != nil {
return prepared, err
}
}
err = verifyPreparedUpdates(refs, prepared)
if err != nil {
return prepared, err
}
return prepared, nil
}
func resolvePreparedUpdates(refs map[string]storedRef, ops []queuedUpdate) ([]preparedUpdate, error) {
prepared := make([]preparedUpdate, 0, len(ops))
targets := make(map[string]struct{}, len(ops))
for _, op := range ops {
target, err := resolveQueuedUpdateTarget(refs, op)
if err != nil {
return prepared, err
}
if _, exists := targets[target.name]; exists {
return prepared, wrapUpdateError(op.name, &refstore.DuplicateUpdateError{})
}
targets[target.name] = struct{}{}
prepared = append(prepared, preparedUpdate{op: op, target: target})
}
return prepared, nil
}
func resolveQueuedUpdateTarget(refs map[string]storedRef, op queuedUpdate) (resolvedUpdateTarget, error) {
switch op.kind {
case updateCreate:
return resolveOrdinaryTarget(refs, op.name, true)
case updateReplace, updateDelete, updateVerify:
return resolveOrdinaryTarget(refs, op.name, false)
case updateCreateSymbolic, updateReplaceSymbolic, updateDeleteSymbolic, updateVerifySymbolic:
return resolvedUpdateTarget{name: op.name, ref: directRead(refs, op.name)}, nil
default:
return resolvedUpdateTarget{}, fmt.Errorf("refstore/memory: unsupported update operation %d", op.kind)
}
}
func resolveOrdinaryTarget(refs map[string]storedRef, name string, allowMissing bool) (resolvedUpdateTarget, error) {
cur := name
seen := make(map[string]struct{})
for {
if _, ok := seen[cur]; ok {
return resolvedUpdateTarget{}, fmt.Errorf("refstore/memory: symbolic reference cycle at %q", cur)
}
seen[cur] = struct{}{}
refState := directRead(refs, cur)
switch refState.kind {
case storedMissing:
if !allowMissing {
return resolvedUpdateTarget{}, wrapUpdateError(name, refstore.ErrReferenceNotFound)
}
return resolvedUpdateTarget{name: cur, ref: refState}, nil
case storedDetached:
return resolvedUpdateTarget{name: cur, ref: refState}, nil
case storedSymbolic:
target := strings.TrimSpace(refState.target)
if target == "" {
return resolvedUpdateTarget{}, wrapUpdateError(name, &refstore.InvalidValueError{
Err: fmt.Errorf("symbolic reference has empty target"),
})
}
cur = target
default:
return resolvedUpdateTarget{}, fmt.Errorf("refstore/memory: unsupported stored reference kind %d", refState.kind)
}
}
}
func directRead(refs map[string]storedRef, name string) storedRef {
stored, ok := refs[name]
if !ok {
return storedRef{kind: storedMissing}
}
return cloneStoredRef(stored)
}
func collectPreparedWrites(prepared []preparedUpdate) (deleted map[string]struct{}, written []string) {
deleted = make(map[string]struct{})
written = make([]string, 0, len(prepared))
for _, item := range prepared {
switch item.op.kind {
case updateDelete, updateDeleteSymbolic:
deleted[item.target.name] = struct{}{}
case updateCreate, updateReplace, updateCreateSymbolic, updateReplaceSymbolic:
written = append(written, item.target.name)
case updateVerify, updateVerifySymbolic:
}
}
return deleted, written
}
func collectVisibleNames(refs map[string]storedRef) map[string]struct{} {
names := make(map[string]struct{}, len(refs))
for name := range refs {
names[name] = struct{}{}
}
return names
}
func verifyRefnameAvailable(name string, existing map[string]struct{}, writes []string, deleted map[string]struct{}) error {
for existingName := range existing {
if existingName == name {
continue
}
if _, skip := deleted[existingName]; skip {
continue
}
if refnamesConflict(name, existingName) {
return wrapUpdateError(name, &refstore.NameConflictError{Other: existingName})
}
}
for _, other := range writes {
if other == name {
continue
}
if refnamesConflict(name, other) {
return wrapUpdateError(name, &refstore.NameConflictError{Other: other})
}
}
return nil
}
func refnamesConflict(left, right string) bool {
return left == right ||
strings.HasPrefix(left, right+"/") ||
strings.HasPrefix(right, left+"/")
}
func verifyPreparedUpdates(refs map[string]storedRef, prepared []preparedUpdate) error {
for i := range prepared {
item := &prepared[i]
item.target.ref = directRead(refs, item.target.name)
err := verifyPreparedUpdateCurrent(*item)
if err != nil {
return err
}
}
return nil
}
func verifyPreparedUpdateCurrent(item preparedUpdate) error {
switch item.op.kind {
case updateCreate:
if item.target.ref.kind != storedMissing {
return wrapUpdateError(item.op.name, &refstore.CreateExistsError{})
}
return nil
case updateReplace, updateDelete, updateVerify:
if item.target.ref.kind == storedMissing {
return wrapUpdateError(item.op.name, refstore.ErrReferenceNotFound)
}
if item.target.ref.kind != storedDetached {
return wrapUpdateError(item.op.name, &refstore.ExpectedDetachedError{})
}
if item.target.ref.id != item.op.oldID {
return wrapUpdateError(item.op.name, &refstore.IncorrectOldValueError{
Actual: item.target.ref.id.String(),
Expected: item.op.oldID.String(),
})
}
return nil
case updateCreateSymbolic:
if item.target.ref.kind != storedMissing {
return wrapUpdateError(item.op.name, &refstore.CreateExistsError{})
}
return nil
case updateReplaceSymbolic, updateDeleteSymbolic, updateVerifySymbolic:
if item.target.ref.kind == storedMissing {
return wrapUpdateError(item.op.name, refstore.ErrReferenceNotFound)
}
if item.target.ref.kind != storedSymbolic {
return wrapUpdateError(item.op.name, &refstore.ExpectedSymbolicError{})
}
if strings.TrimSpace(item.target.ref.target) != strings.TrimSpace(item.op.oldTarget) {
return wrapUpdateError(item.op.name, &refstore.IncorrectOldValueError{
Actual: strings.TrimSpace(item.target.ref.target),
Expected: strings.TrimSpace(item.op.oldTarget),
})
}
return nil
}
return nil
}
func applyPreparedUpdates(refs map[string]storedRef, prepared []preparedUpdate) {
for _, item := range prepared {
switch item.op.kind {
case updateCreate, updateReplace:
refs[item.target.name] = storedRef{kind: storedDetached, id: item.op.newID}
case updateCreateSymbolic, updateReplaceSymbolic:
refs[item.target.name] = storedRef{kind: storedSymbolic, target: strings.TrimSpace(item.op.newTarget)}
case updateDelete, updateDeleteSymbolic:
delete(refs, item.target.name)
case updateVerify, updateVerifySymbolic:
}
}
}
func isBatchRejected(err error) bool {
_, invalidName := errors.AsType[*refstore.InvalidNameError](err)
_, invalidValue := errors.AsType[*refstore.InvalidValueError](err)
_, duplicateUpdate := errors.AsType[*refstore.DuplicateUpdateError](err)
_, createExists := errors.AsType[*refstore.CreateExistsError](err)
_, incorrectOldValue := errors.AsType[*refstore.IncorrectOldValueError](err)
_, expectedDetached := errors.AsType[*refstore.ExpectedDetachedError](err)
_, expectedSymbolic := errors.AsType[*refstore.ExpectedSymbolicError](err)
_, nameConflict := errors.AsType[*refstore.NameConflictError](err)
return errors.Is(err, refstore.ErrReferenceNotFound) ||
invalidName ||
invalidValue ||
duplicateUpdate ||
createExists ||
incorrectOldValue ||
expectedDetached ||
expectedSymbolic ||
nameConflict
}
func batchResultError(err error) error {
updateErr, ok := errors.AsType[*updateContextError](err)
if ok {
return updateErr.err
}
return err
}
func batchResultName(err error) string {
updateErr, ok := errors.AsType[*updateContextError](err)
if !ok {
return ""
}
return updateErr.name
}
// TODO: these really shouldn't be used in the batched path, really...
|