aboutsummaryrefslogtreecommitdiff
path: root/modules
diff options
context:
space:
mode:
authorGravatar jesopo2018-11-06 15:01:02 +0000
committerGravatar jesopo2018-11-06 15:01:02 +0000
commit7c49152ef6d4ac06ba0114b12df45cd0efcc6c4d (patch)
tree0901d90fc8547468ebb29d6f32e43c9313d0baf1 /modules
parentissue_comment is fired for both issue comments AND pull request comments. (diff)
signature
if an issue comment is from a pull request, it's denoted by the presence of
data["issue"]["pull_request"]
Diffstat (limited to 'modules')
-rw-r--r--modules/github.py18
1 files changed, 6 insertions, 12 deletions
diff --git a/modules/github.py b/modules/github.py
index 4b9e1614..b3276647 100644
--- a/modules/github.py
+++ b/modules/github.py
@@ -119,17 +119,11 @@ class Module(ModuleManager.BaseModule):
(full_name, issue_number, author, action, issue_title, url)]
def issue_comment(self, event, full_name, data):
action = data["action"]
-
- number = None
- title = None
- if "issue" in data:
- number = data["issue"]["number"]
- title = data["issue"]["title"]
- elif "pull_request" in data:
- number = data["pull_request"]["number"]
- title = data["pull_request"]["title"]
-
+ issue_number = data["issue"]["number"]
+ issue_title = data["issue"]["title"]
+ type = "pr" if "pull_request" in data["issue"] else "issue"
commenter = data["comment"]["user"]["login"]
url = data["comment"]["html_url"]
- return ["(%s) [issue#%d] %s %s a comment: %s - %s" %
- (full_name, number, commenter, action, title, url)]
+ return ["(%s) [%s#%d] %s %s a comment: %s - %s" %
+ (full_name, type, issue_number, commenter, action, issue_title,
+ url)]